GNOME Bugzilla – Bug 761298
Change the application id
Last modified: 2016-02-29 22:50:14 UTC
The application id used by Swell Foop is: 'org.gnome.swell-foop'. This is not a valid DBus name, because it contains a dash. See: http://dbus.freedesktop.org/doc/dbus-specification.html#message-protocol-names Since application ids go on the session bus, and are used for various other session-like things (like XDG-App), the application id should be changed to a valid DBus name, for instance: org.gnome.swell_foop org.gnome.SwellFoop
I think we should also add a runtime warning in GLib; it should have detected this.
Yes, there's an inconsistency in rules between names on the bus and interface names; the authoritative answer of the DBus maintainer is that it's too late to fix the inconsistency, and that developers should use the strictest subset, which does not allow dashes in a name.
Technically speaking: GApplication is correct. The name on the bus being exported is valid. Thje problem is that XDG-App limits what the bus can export from the sandbox, which means that the application id should match the name on the bus, which should match the interface rules. We could add a warning to GApplication, but obviously it's perfectly legitimate to write applications that work outside the sandbox with that API. XDG-App should warn, and consider '-' and '_' on the app id semantically equivalent; but I'd rather fix the apps while we're finding this issues as well.
Created attachment 322708 [details] [review] Use a valid dbus name as app id (bgo#761298)
The proposed patch only changes the application id, and as far as I see (please correct me if I'm wrong) there's nothing else required. I am not sure if the app-id should match the gschema name, but if possible, I would like to avoid "moving" the settings schema.
Review of attachment 322708 [details] [review]: You don't need to move the settings schema.
Review of attachment 322708 [details] [review]: Pushed to master, closing this bug. If we feel there's a need to validate the application id, feel free to report a bug against glib or xdg-app to warn for similar issues, as reocmmended by Emmanuele.
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.