After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761175 - Masking need to be able to use an object that is being referenced by <use>
Masking need to be able to use an object that is being referenced by <use>
Status: RESOLVED FIXED
Product: librsvg
Classification: Core
Component: general
2.40.x
Other Linux
: Normal normal
: ---
Assigned To: Federico Mena Quintero
librsvg maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-27 13:29 UTC by Sandro Mani
Modified: 2018-03-28 18:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Incorrectly rendered SVG file (1.93 KB, image/svg+xml)
2016-01-27 13:29 UTC, Sandro Mani 		  Details
librsvg-761175-recursive-masks.patch (1.44 KB, patch)
2017-12-01 17:37 UTC, Federico Mena Quintero 		none Details | Review

Description Sandro Mani 2016-01-27 13:29:24 UTC 
Created attachment 319831 [details]
Incorrectly rendered SVG file

The attached SVG file renders incorrectly from commit 3ae509 onwards.
Comment 1 Federico Mena Quintero 2017-11-11 10:56:20 UTC 
May I include that example file in the librsvg soure code as a test?  I think I have a fix for this.
Comment 2 Sandro Mani 2017-11-11 11:23:33 UTC 
Sure!
Comment 3 Günther Schoch 2017-11-30 15:12:06 UTC 
(In reply to Federico Mena Quintero from comment #1)
> May I include that example file in the librsvg soure code as a test?  I
> think I have a fix for this.

May I ask if there is already an update for that issue checked in?
Comment 4 Federico Mena Quintero 2017-12-01 16:27:47 UTC 
Not yet.  I will report here when it is done.
Comment 5 Federico Mena Quintero 2017-12-01 17:37:29 UTC 
Created attachment 364776 [details] [review]
librsvg-761175-recursive-masks.patch

Could you please test this patch?
Comment 6 Günther Schoch 2017-12-02 10:56:17 UTC 
> Could you please test this patch?

thank you. I will ask Sandro as he has the exact test environment. We will reply soon.
Comment 7 Sandro Mani 2017-12-05 09:34:26 UTC 
Looks good, thanks!
Comment 8 Federico Mena Quintero 2017-12-05 12:57:42 UTC 
Thanks for confirming; I'll push this.  Expect a release soon :)
Comment 9 Federico Mena Quintero 2017-12-05 14:16:51 UTC 
Pushed to librsvg-2.40 and master:

librsvg-2.40: fe5711c8785a4ef3582752e2109e54440102c702

master: 6feb907439f298c7c5f39c422bd9ab8edf6ce6c8
Comment 10 Günther Schoch 2018-03-28 15:07:53 UTC 
We noticed that the newest https://www.gtk.org downloads still work with unpatched versions for this bug. Is there a chance to fix the issue in all the currently active branches?
Comment 11 Federico Mena Quintero 2018-03-28 18:10:42 UTC 
The fix in question is in librsvg 2.40.20; you can use that version.  That branch is not maintained anymore; that last tarball is usable by people who can't use the Rust version.

The only supported branch currently is the librsvg-2.42 series.

GTK+ still works with the old one because the librsvg API/ABI has not changed at all.  GTK+ doesn't actually enforce librsvg to be installed; it just assumes that it is, and that the SVG pixbuf loader is available as a result.