GNOME Bugzilla – Bug 760996
background in notebooks (and other places?) now white
Last modified: 2016-02-05 05:50:42 UTC
I got this complaint from the anaconda team, but I am seeing similar things in evolution: patches of background that used to be gray now appear white. The anaconda guys were wondering if this is just the background in notebook pages. See https://openqa.stg.fedoraproject.org/tests/4949/modules/disk_custom_ext3/steps/9/edit for an example
Maybe related, the "Available Space" and "Total Space" boxes in the example show another background color issue. Both of them have background colors set by adding a CssProvider with "GtkViewport { background-color: <color> }" to the style context of the viewport object (#db3279 for available, #60605b for total), but neither is working now.
I haven't yet reviewed the notebbo styling but that looks pretty much like app shipped CSS needing updates to reflect GTK+ changes
Try replacing GtkViewPort by viewport in that css fragment.
Also: whenever you set background-color, you should add background: none to prevent background-images from overriding your color. Or just set background: <your-color>;
Turns out background in notebooks has been white before (see the various notebook examples in gtk3-widget-factory, e.g. in 3.18).
(In reply to Matthias Clasen from comment #3) > Try replacing GtkViewPort by viewport in that css fragment. Thanks, that fixes the viewport colors. How do the other style selectors need to be changed? Anaconda has a handful of other rules with class name selectors, one on GtkTreeView (which is no longer working, now that I remembered to check), and the rest on anaconda's custom widgets.
(In reply to David Shea from comment #6) > (In reply to Matthias Clasen from comment #3) > > Try replacing GtkViewPort by viewport in that css fragment. > > Thanks, that fixes the viewport colors. How do the other style selectors > need to be changed? Anaconda has a handful of other rules with class name > selectors, one on GtkTreeView (which is no longer working, now that I > remembered to check), and the rest on anaconda's custom widgets. Each widget documents its css names now, see. e.g. here for GtkViewport: https://developer.gnome.org/gtk3/3.19/GtkViewport.html#GtkViewport.description A quick (and not 100% reliable table can be found here: https://wiki.gnome.org/Projects/GTK%2B/StyleClasses
Created attachment 320087 [details] an affected application: office-runner
the office-runner and other hidden header notebook cases should be cured with commit a0363e5f0a10703a98ae14971fe13f8aed138aba, not sure it's just that, so leaving this open, feel free to close if the issue is gone though.
can confirm office runner is fixed, the cases of white background in evolution too, Lets assume it is fixed