After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760730 - No name, just date logged
No name, just date logged
Status: RESOLVED FIXED
Product: five-or-more
Classification: Applications
Component: general
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: five-or-more-maint
five-or-more-maint
Depends on:
Blocks:
 
 
Reported: 2016-01-16 21:39 UTC by dracekfi
Modified: 2018-03-21 02:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use libgnome-games-support for scores (67.07 KB, patch)
2018-03-20 15:56 UTC, Ruxandra Simion
committed Details | Review

Description dracekfi 2016-01-16 21:39:42 UTC
There used to be a name (preset the name of the loged in computer user) and score. Now there is just date and score and no way to set it otherwise. We would like to write our names.
Comment 1 Michael Catanzaro 2016-01-17 00:00:20 UTC
This would be a relatively easy task for someone to work on. We have a new library libgames-support which scores player names along with scores. The task would be to remove five-or-more's custom scores handling and use libgames-support instead. There is a wip/libgames-support branch of gnome-robots that could serve as an example.

There is one problem: currently libgames-support is not able to import scores. It would be nice to make this transition without deleting all the users' currently saved scores. (Imported scores would just be given the name of the current user at time of import.)
Comment 2 Robert Roth 2018-02-15 10:24:34 UTC
The initial limitation of libgames-scores not being able to import previous scores seems to be gone, as the library does have an importer mechanism implemented since february 2016. Anyone interested is welcome to jump on the task, patches will be reviewed in a timely manner.
Comment 3 Ruxandra Simion 2018-03-20 15:56:09 UTC
Created attachment 369917 [details] [review]
Use libgnome-games-support for scores

I have also checked to see if old scores are being imported and it seems to be working fine. Please let me know should I change anything in the current patch. Thank you.
Comment 4 Robert Roth 2018-03-21 01:57:20 UTC
Review of attachment 369917 [details] [review]:

Thanks, this looks fine, took me a while to merge with the current split code, but it was not something very tricky. The only thing missing (which I found during merging) is that as gnome-games-support also provides games-gridframe, you could have dropped those files, but I have done that, it is a minor annoyance. Pushed your changes to master.
Comment 5 Robert Roth 2018-03-21 02:09:22 UTC
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.