After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760505 - qtdemux : Fix the Log location about calculating framerate and Do not set the wrong framerate's value to the caps with dash case.
qtdemux : Fix the Log location about calculating framerate and Do not set the...
Status: RESOLVED INVALID
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-12 05:31 UTC by Suhwang Kim
Modified: 2016-01-22 07:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
This is the patch for this Bugzilla. (1.22 KB, patch)
2016-01-12 05:38 UTC, Suhwang Kim
none Details | Review
Do not set framerate to the caps with dash case. (1.87 KB, patch)
2016-01-12 12:13 UTC, Suhwang Kim
none Details | Review

Description Suhwang Kim 2016-01-12 05:31:14 UTC
Log location which is calculating framerate should be moved properly.
Comment 1 Suhwang Kim 2016-01-12 05:38:34 UTC
Created attachment 318836 [details] [review]
This is the patch for this Bugzilla.
Comment 2 Suhwang Kim 2016-01-12 12:13:01 UTC
Created attachment 318854 [details] [review]
Do not set framerate to the caps with dash case.
Comment 3 Thiago Sousa Santos 2016-01-19 14:40:06 UTC
Do you have a sample that shows the problem?
Comment 4 Suhwang Kim 2016-01-20 01:32:20 UTC
Yes, I have a sample as below link.
http://dash.edgesuite.net/dash264/TestCases/1a/sony/SNE_DASH_SD_CASE1A_REVISED.mpd
http://dash.edgesuite.net/dash264/TestCases/1a/qualcomm/1/MultiRate.mpd
and so many cases of dash URL.

There are no problem to play with these URLS.
But when you grep the log message with "qtdemux" and "framerate" as below.
You can find the framerate was set the wrong value to the caps.
Here is the log message with 1.7.1 version of gstreamer.
========
0:00:00.375462516 11052 0x7fda3c147cf0 DEBUG                qtdemux qtdemux.c:1830:gst_qtdemux_setcaps:<qtdemux1> Sink set caps: video/quicktime, width=(int)854, height=(int)480, framerate=(fraction)24000/1001

========
0:00:00.378479031 11052 0x7fda3c147cf0 DEBUG                qtdemux qtdemux.c:6940:gst_qtdemux_configure_stream:<qtdemux1> Calculating framerate, timescale 24000 gave fps_n 24000 fps_d 1
0:00:00.378655740 11052 0x7fda3c147cf0 DEBUG                qtdemux qtdemux.c:7033:gst_qtdemux_configure_stream:<qtdemux1> setting caps video/x-h264, stream-format=(string)avc, alignment=(string)au, level=(string)3, profile=(string)main, codec_data=(buffer)014d401effe1001e674d401e965606c1ef3780a8400000fa40002ee039a80374006ecbdef80801000568ee060cc8, width=(int)854, height=(int)480, framerate=(fraction)24000/1, pixel-aspect-ratio=(fraction)1/1
Comment 5 Suhwang Kim 2016-01-20 01:34:56 UTC
However, I think that this patch is not right method to solve the problem

Our team member has solved this problem with https://bugzilla.gnome.org/show_bug.cgi?id=760779 and 
https://bugzilla.gnome.org/show_bug.cgi?id=760774

Could you please review those Bugzilla?
Comment 6 Sebastian Dröge (slomo) 2016-01-21 13:15:11 UTC
So should this bug be closed and the patches be rejected, and the ones from the other two bugs are the relevant fixes?
Comment 7 Suhwang Kim 2016-01-22 01:45:43 UTC
Yes I think so. This bug be closed. :)
thanks.