GNOME Bugzilla – Bug 760505
qtdemux : Fix the Log location about calculating framerate and Do not set the wrong framerate's value to the caps with dash case.
Last modified: 2016-01-22 07:57:10 UTC
Log location which is calculating framerate should be moved properly.
Created attachment 318836 [details] [review] This is the patch for this Bugzilla.
Created attachment 318854 [details] [review] Do not set framerate to the caps with dash case.
Do you have a sample that shows the problem?
Yes, I have a sample as below link. http://dash.edgesuite.net/dash264/TestCases/1a/sony/SNE_DASH_SD_CASE1A_REVISED.mpd http://dash.edgesuite.net/dash264/TestCases/1a/qualcomm/1/MultiRate.mpd and so many cases of dash URL. There are no problem to play with these URLS. But when you grep the log message with "qtdemux" and "framerate" as below. You can find the framerate was set the wrong value to the caps. Here is the log message with 1.7.1 version of gstreamer. ======== 0:00:00.375462516 11052 0x7fda3c147cf0 DEBUG qtdemux qtdemux.c:1830:gst_qtdemux_setcaps:<qtdemux1> Sink set caps: video/quicktime, width=(int)854, height=(int)480, framerate=(fraction)24000/1001 ======== 0:00:00.378479031 11052 0x7fda3c147cf0 DEBUG qtdemux qtdemux.c:6940:gst_qtdemux_configure_stream:<qtdemux1> Calculating framerate, timescale 24000 gave fps_n 24000 fps_d 1 0:00:00.378655740 11052 0x7fda3c147cf0 DEBUG qtdemux qtdemux.c:7033:gst_qtdemux_configure_stream:<qtdemux1> setting caps video/x-h264, stream-format=(string)avc, alignment=(string)au, level=(string)3, profile=(string)main, codec_data=(buffer)014d401effe1001e674d401e965606c1ef3780a8400000fa40002ee039a80374006ecbdef80801000568ee060cc8, width=(int)854, height=(int)480, framerate=(fraction)24000/1, pixel-aspect-ratio=(fraction)1/1
However, I think that this patch is not right method to solve the problem Our team member has solved this problem with https://bugzilla.gnome.org/show_bug.cgi?id=760779 and https://bugzilla.gnome.org/show_bug.cgi?id=760774 Could you please review those Bugzilla?
So should this bug be closed and the patches be rejected, and the ones from the other two bugs are the relevant fixes?
Yes I think so. This bug be closed. :) thanks.