After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760190 - configure.ac should be able to build --with-icu without icu-config tool
configure.ac should be able to build --with-icu without icu-config tool
Status: RESOLVED FIXED
Product: libxml2
Classification: Platform
Component: general
git master
Other Mac OS
: Normal normal
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-06 00:09 UTC by David Kilzer
Modified: 2016-04-30 14:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch v1 (2.59 KB, patch)
2016-01-20 00:24 UTC, David Kilzer 		none Details | Review

Description David Kilzer 2016-01-06 00:09:23 UTC 
Apple builds libxml2 with the equivalent of the following configure switches:

./configure --prefix=/usr --without-iconv --with-icu --without-lzma --with-zlib

However, we don't install icu-config as part of the ICU library, so this fails without a fallback mechanism in configure.ac.
Comment 1 David Kilzer 2016-01-06 00:11:11 UTC 
See also:  Bug 663214: unicode/ucnv.h: No such file or directory with --prefix

This is about honoring an ICU_CONFIG environment variable for the full path to icu-config when running the configure script.
Comment 2 David Kilzer 2016-01-20 00:24:23 UTC 
Created attachment 319391 [details] [review]
Patch v1
Comment 3 David Kilzer 2016-04-29 19:59:28 UTC 
This was fixed in 6e3af87055d2c868d20d8b2b9da59bbafe84e5e0.

<https://git.gnome.org/browse/libxml2/commit/?id=6e3af87055d2c868d20d8b2b9da59bbafe84e5e0>
Comment 4 David Kilzer 2016-04-30 14:35:41 UTC 
I should note that the original patch to support ICU without icu-config was written by Mark Rowe at Apple.  When upstreaming, I merely tweaked the location of a couple lines, but forgot to change the author in git.  Sorry about that, Mark.