After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760149 - [review] bg/helper-macros-bgo760149 - Use helper macros everywhere
[review] bg/helper-macros-bgo760149 - Use helper macros everywhere
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2016-01-05 10:29 UTC by Beniamino Galvani
Modified: 2016-01-06 20:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Beniamino Galvani 2016-01-05 10:29:17 UTC 
Some patches to use nm_clear_g_source(), nm_clear_g_signal_handler(), NM_PLATFORM_GET everywhere, plus some other related (and one unrelated) patches. Please review.
Comment 1 Beniamino Galvani 2016-01-05 10:31:08 UTC 
Branch bg/helper-macros-bgo760149.
Comment 2 Thomas Haller 2016-01-05 11:01:58 UTC 
>> core: use NM_PLATFORM_GET instead of nm_platform_get() in function calls
    
the idea was to use NM_PLATFORM_GET in places where we call a nm_platform() function without having a platform instance around.
Contrary to 
  g_signal_connect (nm_platform_get (), NM_PLATFORM_SIGNAL_LINK_CHANGED,
where we explicitly want to access the platform instance.

I guess the distinction is too subtle, so fine with me to use NM_PLATFORM_GET everywhere.



Rest LGTM