GNOME Bugzilla – Bug 760097
GtkShortcutsWindow: Gestures not shown correctly in search results
Last modified: 2016-01-03 16:13:04 UTC
When searching for a shortcut in a shortcuts window which also has gestures defined (for example the "zoom" shortcuts in eog) the search results display the gestures without icons and subtitles.
Created attachment 318181 [details] [review] show icons and subtitles for gestures again This apparently got broken during the unification of GtkShortcutsGesture and GtkShortcutsShortcut. The fix is to simply copy the necessary fields in to the new shortcut instance that is created for the search results. I also went the extra mile to ensure that the new instance can still distinguish between gtk-defined icons and subtitles and custom ones.
Created attachment 318182 [details] [review] Separate gestures and accelerators in search results again It seems that gestures and keyboard shortcuts where shown separately in the search results before. Not sure if that's still desired, but this will restore that behaviour again. Otherwise the search_gestures box can likely be dropped.
Review of attachment 318181 [details] [review]: yes, looks good.
Review of attachment 318182 [details] [review]: Commit message probably wanted to say "...from other shortcuts...". Otherwise, looks good.
(In reply to Matthias Clasen from comment #5) > Review of attachment 318182 [details] [review] [review]: > > Commit message probably wanted to say "...from other shortcuts...". Yes. :) commit daa08862ffae16a78dba297cf796fb577b9d9b08 Author: Felix Riemann <> Date: Sun Jan 3 15:32:38 2016 +0100 shortcuts: Separate gestures in search results Gestures where shown separately from other shortcuts in the search results before. This restores that behaviour. https://bugzilla.gnome.org/show_bug.cgi?id=760097 commit bd4b3091f6e1f900d4a3effcfd93d7c97f46ef1c Author: Felix Riemann <> Date: Sun Jan 3 15:22:06 2016 +0100 shortcuts: Show icons and subtitles for gestures in search results https://bugzilla.gnome.org/show_bug.cgi?id=760097