After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759898 - W32: There's a gap between tooltip window and its shadow
W32: There's a gap between tooltip window and its shadow
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-12-27 05:11 UTC by LRN
Modified: 2016-01-14 14:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GDK W32: Don't use WM-drawn shadow for tooltips (1.37 KB, patch)
2015-12-27 05:11 UTC, LRN
committed Details | Review

Description LRN 2015-12-27 05:11:48 UTC
It's because the shadow does not come from Adwaita, it's drawn by
the WM, because tooltips have CS_DROPSHADOW class style.
Comment 1 LRN 2015-12-27 05:11:59 UTC
Created attachment 317920 [details] [review]
GDK W32: Don't use WM-drawn shadow for tooltips

This prevents WM from drawing shadows around tooltip windows,
which, in Adwaita, should have no shadow and are CSD-ish (which means
that tooltip window is larger than it looks, and WM draws the shadow
only on the outside, leaving a gap between the visible tooltip edge and
the shadow).
Comment 2 LRN 2015-12-27 05:14:17 UTC
Note that this will remove shadows from non-CSD-ish tooltips (such as when desktop composition is off). Not that anyone cares.

I thought about disabling shadows on a per-window basis, but CS_DROPSHADOW is a *class* style, it will affect *all* tooltip windows made by a given GTK process.
Comment 3 Ignacio Casal Quinteiro (nacho) 2016-01-14 13:08:12 UTC
Review of attachment 317920 [details] [review]:

OK
Comment 4 LRN 2016-01-14 14:56:08 UTC
Attachment 317920 [details] pushed as 37bd22c - GDK W32: Don't use WM-drawn shadow for tooltips