After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759452 - directsoundsink: check device property, don't use default if a specific device is set
directsoundsink: check device property, don't use default if a specific devic...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Windows
: Normal enhancement
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-12-14 13:51 UTC by Thomas Roos
Modified: 2015-12-14 14:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add a check and give an error if a specific device is set via device property, but not found (1.19 KB, patch)
2015-12-14 13:57 UTC, Thomas Roos 		committed Details | Review

Description Thomas Roos 2015-12-14 13:51:03 UTC 
directsoundsink will not check device property and use the default device if a specific device is set
-> I think it should not use the default device if device property is set and give an error instead, when not setting an specific device using the default is ok.
Comment 1 Thomas Roos 2015-12-14 13:57:59 UTC 
Created attachment 317366 [details] [review]
add a check and give an error if a specific device is set via device property, but not found
Comment 2 Sebastian Dröge (slomo) 2015-12-14 14:50:18 UTC 
commit adb5efaf8a9a5b4b6590c637f9054f5df8f2b2a1
Author: Thomas Roos <thomas.roos@industronic.de>
Date:   Mon Dec 14 14:55:12 2015 +0100

    directsoundsink: Check device property and fail if device can't be found
    
    Don't use default if a specific device is set but it can't be found.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=759452