After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759350 - GspellInlineCheckerGtv: remove attach_view() and detach_view()
GspellInlineCheckerGtv: remove attach_view() and detach_view()
Status: RESOLVED FIXED
Product: gspell
Classification: Other
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gspell maintainers
gspell maintainers
Depends on:
Blocks:
 
 
Reported: 2015-12-11 13:39 UTC by Sébastien Wilmet
Modified: 2016-01-06 17:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sébastien Wilmet 2015-12-11 13:39:37 UTC 
Instead of taking a GtkTextBuffer as the constructor argument, it should take a GtkTextView instead. So that attaching/detaching views is not necessary for the application. The gspell implementation should take care itself about buffer changes, add the GtkTextTag's to the right buffer and if several views share the same buffer, don't add two times the tags.

The gspell implementation would be more complicated, but the API would be more user-friendly.
Comment 1 Sébastien Wilmet 2016-01-06 17:45:50 UTC 
Fixed!