After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759145 - [Patch] souphttpclientsink: Add buffers-max to limit the number of buffers ever attempted in a single PUT.
[Patch] souphttpclientsink: Add buffers-max to limit the number of buffers ev...
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Mac OS
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-12-07 21:35 UTC by minfrin
Modified: 2018-11-03 15:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add buffers-max to limit the number of buffers ever attempted in a single PUT (5.27 KB, patch)
2015-12-07 21:35 UTC, minfrin
none Details | Review

Description minfrin 2015-12-07 21:35:56 UTC
Created attachment 316906 [details] [review]
Add buffers-max to limit the number of buffers ever attempted in a single PUT

Add buffers-max to limit the number of buffers ever attempted in a single PUT.

To write a single buffer at a time (for example, thumbnail images)
set this to 1.

Defaults to zero, meaning unlimited.
Comment 1 Tim-Philipp Müller 2016-05-13 09:37:59 UTC
Thanks for the patch. Could you expand on the use case for this?
Comment 2 minfrin 2016-05-13 09:58:20 UTC
We have two.

The first is that we need to limit the length of the total size of the HTTP body, as further downstream processing is taking place that isn't able to work on unbounded data sizes.

The second is that on particular case we're generating thumbnails and submitting it to a service via HTTP. Right now, two or more thumbnails are concatenated together by gstreamer and that makes life hard for the downstream service, which wants images one at a time.

The current behaviour is effectively unbounded, and creates all sorts of failure cases which can be avoided if the souphttpclientsink can be told to pause once it reaches a certain size, allowing the gstreamer queue to soak up the delay.
Comment 3 minfrin 2016-08-28 11:24:31 UTC
Quick bump on this one, would it be possible to respond to the comment above?
Comment 4 Edward Hervey 2018-05-07 14:25:11 UTC
This would only matter in multiplexed/chunked mode, no ?

Also Is it still valid ?
Comment 5 GStreamer system administrator 2018-11-03 15:06:34 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/244.