After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759085 - seg fault in actor-graph test
seg fault in actor-graph test
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: conformance
1.24.x
Other OpenBSD
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2015-12-06 12:42 UTC by Nigel Taylor
Modified: 2017-05-05 13:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
conform/actor-graph: Add missing null-termination (1019 bytes, patch)
2017-05-05 13:38 UTC, Jeremy Bicha 		committed Details | Review

Description Nigel Taylor 2015-12-06 12:42:53 UTC 
Needed to apply this patch to stop the seg fault. Missing NULL to end list of strings.

$OpenBSD$
--- tests/conform/actor-graph.c.orig    Sat Jul 11 10:18:18 2015
+++ tests/conform/actor-graph.c Fri Dec  4 02:11:10 2015
@@ -350,7 +350,8 @@ actor_replace_child (void)
   g_assert_cmpstr (clutter_actor_get_name (iter), ==, "qux");
 
   clutter_actor_add_child (actor, g_object_new (CLUTTER_TYPE_ACTOR,
-                                                "name", "foo"));
+                                                "name", "foo",
+                                               NULL));
 
   clutter_actor_replace_child (actor, iter,
                                g_object_new (CLUTTER_TYPE_ACTOR,
Comment 1 Jeremy Bicha 2017-05-05 13:38:48 UTC 
Created attachment 351200 [details] [review]
conform/actor-graph: Add missing null-termination

I was able to trigger this bug on armhf but not on other typical Ubuntu architectures. (It looks s390x is also affected.)

But with this patch, the actor-graph tests passed on armhf.

You can see the test failure by clicking armhf at
https://launchpad.net/ubuntu/+source/mutter/3.24.1-0ubuntu2

(Yes, I know it's mutter but it happens the same way with clutter)
Comment 2 Emmanuele Bassi (:ebassi) 2017-05-05 13:43:28 UTC 
Review of attachment 351200 [details] [review]:

Oh, indeed. Nice catch!
Comment 3 Jeremy Bicha 2017-05-05 13:47:13 UTC 
Attachment 351200 [details] pushed as 9196768 - conform/actor-graph: Add missing null-termination