After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759081 - Add 'nullable' to return type of gtk_cell_layout_get_area.
Add 'nullable' to return type of gtk_cell_layout_get_area.
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-12-06 02:51 UTC by Erika
Modified: 2015-12-07 11:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to add nullable annotation to gtk_cell_layout_get_area (494 bytes, patch)
2015-12-06 02:51 UTC, Erika 		none Details | Review
Patch to add nullable annotation to gtk_cell_layout_get_area (v2) (538 bytes, patch)
2015-12-06 14:31 UTC, Erika 		accepted-commit_now Details | Review

Description Erika 2015-12-06 02:51:52 UTC 
Created attachment 316831 [details] [review]
Patch to add nullable annotation to gtk_cell_layout_get_area

Else get_area() can't be overridden in Vala in a way that returns null.
Comment 1 Timm Bäder 2015-12-06 09:24:14 UTC 
That change is indeed correct, yes. Can you also change the Returns: comment to say the usual "or %NULL in case no cell area is used" or something similar? It's slightly redundant since the docs above already mention it, but I think it's better to be explicit in that case (and when people scan the docs for return types, they don't have to read the paragraph above).
Comment 2 Erika 2015-12-06 14:31:51 UTC 
Created attachment 316843 [details] [review]
Patch to add nullable annotation to gtk_cell_layout_get_area (v2)
Comment 3 Matthias Clasen 2015-12-06 17:09:15 UTC 
Review of attachment 316843 [details] [review]:

ok