After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759006 - Add GSettings support to Orca
Add GSettings support to Orca
Status: RESOLVED DUPLICATE of bug 619398
Product: orca
Classification: Applications
Component: general
3.19.x
Other Linux
: Normal enhancement
: ---
Assigned To: Orca Maintainers
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-12-04 05:42 UTC by Luke Yelavich
Modified: 2015-12-08 23:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GSettings backend patch (44.94 KB, patch)
2015-12-04 05:42 UTC, Luke Yelavich
none Details | Review

Description Luke Yelavich 2015-12-04 05:42:34 UTC
Created attachment 316742 [details] [review]
GSettings backend patch

Attached is a patch that implements gsettings support for Orca as a new backend.

Some notes:
* The patch also enables the GSettings backend by default
* No code has been written to migrate user settings from json to gsettings.
* I have attempted to make the GSettings backend 100% compatible with how the JSON backend works, such that Orca should still function just as it does with the JSON backend.

One small bug I've found is voice settings reverting to defaults when saving app settings, although this is not reflected in what is saved, only what is heard. This bug has only arisen since I refactored the code such that all save and load calls use a similar code path, and was not present in my earlier, unoptimized, massively duplicated code. I hope to address this cosmetic issue next week.
Comment 1 Allison Karlitskaya (desrt) 2015-12-08 16:09:52 UTC
Probable dup of bug 619398.
Comment 2 Luke Yelavich 2015-12-08 23:03:07 UTC

*** This bug has been marked as a duplicate of bug 619398 ***