After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758891 - queue2 buffers huge data than required
queue2 buffers huge data than required
Status: RESOLVED DUPLICATE of bug 763801
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-12-01 08:32 UTC by pavan goyal
Modified: 2017-11-23 17:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to use out rate for buffering (1.63 KB, patch)
2015-12-01 08:35 UTC, pavan goyal
none Details | Review

Description pavan goyal 2015-12-01 08:32:33 UTC
queue2 is buffering huge data as compared to what is required.

when a 5 Mbps (bits per second) stream is played from http, and http server is aloowing at 20MBps (160mbps) then if we set a time limit for buffering on queue2 for example 500ms then queue2 buffers approx 10 MB (10 M Bytes or 80 Mbits) but it should have buffered only 2.5 Mb or 2.5 MB.

issue is because, queue2 set current level as per in rate instead of outrate. since decoding will happen on out rate only not more than that so queue2 should buffer as per output rate not input rate.

input rate may go too high or low based on network bandwidth.
Comment 1 pavan goyal 2015-12-01 08:35:21 UTC
Created attachment 316576 [details] [review]
patch to use out rate for buffering

buffering works fine with attached patch and no extra memory is consumed. so it more memory efficient.
Comment 2 pavan goyal 2015-12-01 08:36:20 UTC
please review the patch and let me know your feedback. on my embedded platform, i see a lot memory saved with this and also buffering is sufficient.
Comment 3 Vincent Penquerc'h 2016-03-18 13:15:19 UTC
This seems sensible to me. There might be odd values at start if it bursts, though.
Comment 4 Vincent Penquerc'h 2016-03-22 14:23:28 UTC
In fact, it seems it is supposed to be that way, see https://bugzilla.gnome.org/show_bug.cgi?id=763801
Comment 5 Edward Hervey 2017-11-23 17:12:13 UTC

*** This bug has been marked as a duplicate of bug 763801 ***