After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758793 - Update style
Update style
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-29 04:26 UTC by Trinh Anh Ngoc
Modified: 2016-06-19 14:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Update CSS nodes and cleanup (1.86 KB, patch)
2015-11-29 04:27 UTC, Trinh Anh Ngoc 		committed Details | Review
Fix gtk warnings (1.78 KB, patch)
2015-11-29 04:28 UTC, Trinh Anh Ngoc 		committed Details | Review
EvSidebarAnnotations: remove unnecessary top margin (932 bytes, patch)
2015-11-29 04:30 UTC, Trinh Anh Ngoc 		committed Details | Review
Workaround for GtkSearchBar 1px bug (1.06 KB, patch)
2015-11-29 04:31 UTC, Trinh Anh Ngoc 		none Details | Review
Style annotations toolbar (562 bytes, patch)
2015-11-29 04:32 UTC, Trinh Anh Ngoc 		committed Details | Review
Screenshot (13.44 KB, image/png)
2015-11-29 04:46 UTC, Trinh Anh Ngoc 		  Details

Description Trinh Anh Ngoc 2015-11-29 04:26:18 UTC 
A update for Gtk+ 3.19 CSS changes
https://wiki.gnome.org/Projects/GTK%2B/StyleClasses
Comment 1 Trinh Anh Ngoc 2015-11-29 04:27:29 UTC 
Created attachment 316457 [details] [review]
Update CSS nodes and cleanup
Comment 2 Trinh Anh Ngoc 2015-11-29 04:28:34 UTC 
Created attachment 316458 [details] [review]
Fix gtk warnings
Comment 3 Trinh Anh Ngoc 2015-11-29 04:30:05 UTC 
Created attachment 316459 [details] [review]
EvSidebarAnnotations: remove unnecessary top margin
Comment 4 Trinh Anh Ngoc 2015-11-29 04:31:30 UTC 
Created attachment 316460 [details] [review]
Workaround for GtkSearchBar 1px bug
Comment 5 Trinh Anh Ngoc 2015-11-29 04:32:27 UTC 
Created attachment 316461 [details] [review]
Style annotations toolbar
Comment 6 Trinh Anh Ngoc 2015-11-29 04:46:04 UTC 
Created attachment 316462 [details]
Screenshot
Comment 7 Carlos Garcia Campos 2015-12-02 10:23:00 UTC 
Thanks for the patches, are those changes compatible with previous versions of GTK?
Comment 8 Trinh Anh Ngoc 2015-12-02 13:04:58 UTC 
No, it isn't.
Comment 9 Germán Poo-Caamaño 2016-01-09 00:41:41 UTC 
None of them?
Comment 10 Carlos Garcia Campos 2016-06-19 11:33:14 UTC 
Comment on attachment 316457 [details] [review]
Update CSS nodes and cleanup

I've split this in two patches, and updated to use CSS names instead of widgets names.
Comment 11 Carlos Garcia Campos 2016-06-19 11:34:13 UTC 
Comment on attachment 316460 [details] [review]
Workaround for GtkSearchBar 1px bug

What's exactly the problem here? is this still needed?
Comment 12 Carlos Garcia Campos 2016-06-19 11:35:08 UTC 
Thanks for the patches, I've pushed all except the GtkSearchBar thing that I don't understand.
Comment 13 Trinh Anh Ngoc 2016-06-19 14:31:00 UTC 
(In reply to Carlos Garcia Campos from comment #11)
> Comment on attachment 316460 [details] [review] [review]
> Workaround for GtkSearchBar 1px bug
> 
> What's exactly the problem here? is this still needed?

About bottom border of GtkSearchBar. Anyway, this is ugly hack. Let's close this bug. Thank you.