After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758613 - backends/native/meta-cursor-renderer-native.c:261: SIGSEGV: sdl2 app 0ad
backends/native/meta-cursor-renderer-native.c:261: SIGSEGV: sdl2 app 0ad
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
3.18.x
Other Linux
: Normal major
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2015-11-24 18:22 UTC by Mike Mestnik
Modified: 2016-01-11 13:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Full gdb log. (11.96 KB, text/plain)
2015-11-24 18:22 UTC, Mike Mestnik 		  Details
cursor-renderer-native: Avoid a crash if we fail to allocate a gbm bo (983 bytes, patch)
2016-01-08 15:16 UTC, Rui Matos 		committed Details | Review

Description Mike Mestnik 2015-11-24 18:22:08 UTC 
Created attachment 316193 [details]
Full gdb log.

When moving mouse gnome-shell --wayland --display-server crashes.

+ Trace 235759

  • #0 has_valid_cursor_sprite_gbm_bo
    at backends/native/meta-cursor-renderer-native.c line 261
  • #1 should_have_hw_cursor
    at backends/native/meta-cursor-renderer-native.c line 292
  • #2 meta_cursor_renderer_native_update_cursor
    at backends/native/meta-cursor-renderer-native.c line 360
  • #3 update_cursor
    at backends/meta-cursor-renderer.c line 132
  • #4 meta_cursor_renderer_set_cursor
    at backends/meta-cursor-renderer.c line 164
  • #5 update_displayed_cursor
    at backends/meta-cursor-tracker.c line 76
  • #6 sync_cursor
    at backends/meta-cursor-tracker.c line 91
  • #7 set_window_cursor
    at backends/meta-cursor-tracker.c line 166
  • #8 meta_cursor_tracker_set_window_cursor
    at backends/meta-cursor-tracker.c line 329
  • #9 meta_wayland_pointer_update_cursor_surface
    at wayland/meta-wayland-pointer.c line 762
  • #10 ffi_call_SYSV
    from /usr/lib/i386-linux-gnu/libffi.so.6
  • #11 ffi_call
    from /usr/lib/i386-linux-gnu/libffi.so.6
  • #12 ??
    from /usr/lib/i386-linux-gnu/libwayland-server.so.0
  • #13 ??
    from /usr/lib/i386-linux-gnu/libwayland-server.so.0
  • #14 ??
    from /usr/lib/i386-linux-gnu/libwayland-server.so.0
  • #15 wl_event_loop_dispatch
    from /usr/lib/i386-linux-gnu/libwayland-server.so.0
  • #16 wayland_event_source_dispatch
    at wayland/meta-wayland.c line 85
  • #17 g_main_context_dispatch
    from /lib/i386-linux-gnu/libglib-2.0.so.0
  • #18 ??
    from /lib/i386-linux-gnu/libglib-2.0.so.0
  • #19 g_main_loop_run
    from /lib/i386-linux-gnu/libglib-2.0.so.0
  • #20 meta_run
    at core/main.c line 437
  • #21 main 






Comment 1


Rui Matos





          2016-01-08 15:16:15 UTC
        



Created attachment 318501 [details] [review]
cursor-renderer-native: Avoid a crash if we fail to allocate a gbm bo

--

There are other places that could be making similar checks but I don't
think they can be hit. Jonas, should we add more checks?

It might be preferable to have a MetaCursorSpriteNative subclass
instead.






Comment 2


Jonas Ådahl





          2016-01-11 04:22:16 UTC
        



Review of attachment 318501 [details] [review]:

Looks good to me.






Comment 3


Rui Matos





          2016-01-11 13:34:28 UTC
        



Attachment 318501 [details] pushed as 19d814c - cursor-renderer-native: Avoid a crash if we fail to allocate a gbm bo