After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758571 - Don't override prompt from PAM when setting a new password
Don't override prompt from PAM when setting a new password
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
3.18.x
Other Linux
: Normal minor
: ---
Assigned To: GDM maintainers
GDM maintainers
: 745081 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-11-24 00:41 UTC by Michael Catanzaro
Modified: 2016-01-12 22:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
session-worker: Don't override prompt from PAM when setting new password (1.60 KB, patch)
2015-11-24 00:43 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2015-11-24 00:41:18 UTC 
During the PAM authorize step, if pam_acct_mgmt returns PAM_NEW_AUTHTOK_REQD, gdm displays the message "Your password has expired, please change it now." But pam_unix has already displayed the message "You are required to change your password immediately (root enforced)." This causes the message from PAM to flash very briefly on the screen, then be replaced by the message from gdm. The user will be confused by the disappearing message.

I don't think there's any value in gdm presenting its own message here, since the message from PAM is fine. I guess it could be useful only if there is some hypothetical situation where PAM might not prompt, but I think that would be a bug in PAM, right?
Comment 1 Michael Catanzaro 2015-11-24 00:43:26 UTC 
Created attachment 316127 [details] [review]
session-worker: Don't override prompt from PAM when setting new password

During the PAM authorize step, if pam_acct_mgmt returns
PAM_NEW_AUTHTOK_REQD, gdm displays the message "Your password has
expired, please change it now." But pam_unix has already displayed the
message "You are required to change your password immediately (root
enforced)." This causes the message from PAM to flash very briefly on
the screen, then be replaced by the message from gdm. The user will be
confused by the disappearing message.

There's no value in gdm presenting its own message here, since the
message from PAM is fine.
Comment 2 Michael Catanzaro 2016-01-05 21:53:27 UTC 
Attachment 316127 [details] pushed as 0113cec - session-worker: Don't override prompt from PAM when setting new password
Comment 3 Michael Catanzaro 2016-01-12 22:30:33 UTC 
*** Bug 745081 has been marked as a duplicate of this bug. ***