After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758229 - missing scrolling
missing scrolling
Status: RESOLVED FIXED
Product: gnome-logs
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-logs maintainer(s)
gnome-logs maintainer(s)
: 763476 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-11-17 14:22 UTC by Matthias Clasen
Modified: 2016-03-14 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (302.79 KB, image/png)
2015-11-17 14:22 UTC, Matthias Clasen
  Details
Patch (36.57 KB, patch)
2016-02-01 06:25 UTC, Jonathan Kang
committed Details | Review

Description Matthias Clasen 2015-11-17 14:22:32 UTC
Created attachment 315749 [details]
screenshot

I'll attach a screenshot that shows two problems:

1) Cutting off the title like that is dum :-)
  (ie it should say 'systemd-coredump', not 'systemd-coredum')

2) The window extends far beyond my screen, because there is no provision for scrolling the long message.
Comment 1 Jonathan Kang 2016-02-01 06:25:23 UTC
Created attachment 320166 [details] [review]
Patch

For the first problem, the name is not cut by Logs. Logs just fetch the _COMM field value in systemd as the title. So that's not a problem of Logs.

For the second problem, patch attached to solve it.
Comment 2 Jonathan Kang 2016-02-01 10:07:46 UTC
Oh, I see. For the first problem, I can confirm it. I'll spend some time later on to fix it.

Thanks for the report.
Comment 3 Jonathan Kang 2016-02-18 06:36:47 UTC
For the title cut off issue. It's a kernel limitation on field length. So if we keep only using _COMM to display the title, the issue will exist util some fixes have been done at kernel side.

As a workaround, we can detect if the length of _COMM field is smaller than 15. If it isn't, we use another field such as SYSLOG_IDENTIFIER as the title.
Comment 4 Jonathan Kang 2016-02-19 02:12:03 UTC
(In reply to Matthias Clasen from comment #0)
> Created attachment 315749 [details]
> screenshot
> 
> I'll attach a screenshot that shows two problems:
> 
> 1) Cutting off the title like that is dum :-)
>   (ie it should say 'systemd-coredump', not 'systemd-coredum')
> 
For the title cut off problem, it's discussed in bug #739780. Let's discuss it there.
Comment 5 Jonathan Kang 2016-03-11 07:15:52 UTC
*** Bug 763476 has been marked as a duplicate of this bug. ***
Comment 6 David King 2016-03-14 13:24:23 UTC
Review of attachment 320166 [details] [review]:

Pushed to master as commit 5a7f1a196e8ed585d197c8990bf4f5cea003fb16.