After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757947 - adaptivedemux: http src errors are no longer detected
adaptivedemux: http src errors are no longer detected
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-11 14:10 UTC by Florin Apostol
Modified: 2015-11-16 04:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.09 KB, patch)
2015-11-11 14:11 UTC, Florin Apostol 		none Details | Review
proposed patch (1.12 KB, patch)
2015-11-11 16:52 UTC, Florin Apostol 		committed Details | Review

Description Florin Apostol 2015-11-11 14:10:15 UTC 
Since uri handler element was moved to a bin element inside adaptive demux (commit ccff3be3ab2e5bffcefc12c80a5edb225801f1b9) the error messages emitted by the uri handler are not properly handled by adaptivedemux.
Comment 1 Florin Apostol 2015-11-11 14:11:25 UTC 
Created attachment 315265 [details] [review]
proposed patch
Comment 2 Sebastian Dröge (slomo) 2015-11-11 14:18:02 UTC 
Comment on attachment 315265 [details] [review]
proposed patch

You could check instead with gst_object_has_as_ancestor() if the source of the message is inside the bin. That would be more reliable and also catch errors from e.g. queue2.
Comment 3 Florin Apostol 2015-11-11 16:52:37 UTC 
Created attachment 315287 [details] [review]
proposed patch

using gst_object_has_as_ancestor
Comment 4 Sebastian Dröge (slomo) 2015-11-11 16:57:04 UTC 
commit 4994f068d55945ef0c1cf9fc4c349551563b8522
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Wed Nov 11 16:51:23 2015 +0000

    adaptivedemux: fixed handling errors emitted by uri handler
    
    https://bugzilla.gnome.org/show_bug.cgi?id=757947