Created attachment 315247 [details] [review]
shell: let GtkApplication load the appmenu

Since bgo#757828 introduced g_application_set_resource_base_path,
we don't need to use a GtkBuilder to load the appmenu.

GtkApplication automatically loads menus from the GtkBuilder resource
located at "gtk/menus.ui", relative to the application's resource
base path (see g_application_set_resource_base_path ()). The menu
with the ID "app-menu" is taken as the application's app menu.

Review of attachment 315247 [details] [review]:

So, I guess this also depends on a specific version of GTK.

::: shell/evince.gresource.xml
@@ +22,2 @@
   </gresource>
   <gresource prefix="/org/gnome/evince/shell">

So, we should definitely rename this I think :-)

Created attachment 316755 [details] [review]
shell: let GtkApplication load the appmenu

Since bgo#757828 introduced g_application_set_resource_base_path,
we don't need to use a GtkBuilder to load the appmenu.

GtkApplication automatically loads menus from the GtkBuilder resource
located at "gtk/menus.ui", relative to the application's resource
base path (see g_application_set_resource_base_path ()). The menu
with the ID "app-menu" is taken as the application's app menu.

(In reply to Carlos Garcia Campos from comment #2)
> Review of attachment 315247 [details] [review] [review]:
> 
> So, I guess this also depends on a specific version of GTK.
> 
> ::: shell/evince.gresource.xml
> @@ +22,2 @@
>    </gresource>
>    <gresource prefix="/org/gnome/evince/shell">
> 
> So, we should definitely rename this I think :-)

you're right. let's let this sleep for a while then.

Since https://bugzilla.gnome.org/show_bug.cgi?id=757828 got merged, can you review this again?

Comment on attachment 316755 [details] [review]
shell: let GtkApplication load the appmenu

Sure!

Attachment 316755 [details] pushed as a05ec4a - shell: let GtkApplication load the appmenu