After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757903 - mpd verification broke http://www.bok.net/dash/tears_of_steel/cleartext/stream.mpd
mpd verification broke http://www.bok.net/dash/tears_of_steel/cleartext/strea...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-10 17:20 UTC by Jan Schmidt
Modified: 2015-11-18 17:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mpdparser: Also allow '/' in RepresentationID (1.80 KB, patch)
2015-11-11 15:14 UTC, Sebastian Dröge (slomo) 		none Details | Review
mpdparser: Also allow '/' in RepresentationID (2.95 KB, patch)
2015-11-13 15:37 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Jan Schmidt 2015-11-10 17:20:51 UTC 
http://www.bok.net/dash/tears_of_steel/cleartext/stream.mpd used to play, but no longer does.

It was broken by:

commit b8df6cc316f76eda5f592a70a7d0a69cf6eeb9f8
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Tue Sep 29 16:17:03 2015 +0100

    mpdparser: validate representation set identifier
    
    It must have no whitespace, and must comply with RFC 1738 when
    used to build a URL.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750852
Comment 1 Sebastian Dröge (slomo) 2015-11-11 15:14:06 UTC 
Created attachment 315271 [details] [review]
mpdparser: Also allow '/' in RepresentationID

Used by http://www.bok.net/dash/tears_of_steel/cleartext/stream.mpd
Comment 2 Jan Schmidt 2015-11-11 15:24:30 UTC 
Thanks, that fixes it :)
Comment 3 Thiago Sousa Santos 2015-11-13 13:22:01 UTC 
Review of attachment 315271 [details] [review]:

Also needs to fix the tests to allow /
Comment 4 Sebastian Dröge (slomo) 2015-11-13 15:37:14 UTC 
Created attachment 315414 [details] [review]
mpdparser: Also allow '/' in RepresentationID

Used by http://www.bok.net/dash/tears_of_steel/cleartext/stream.mpd
Comment 5 Thiago Sousa Santos 2015-11-18 15:54:49 UTC 
Review of attachment 315414 [details] [review]:

Good, please merge.
Comment 6 Sebastian Dröge (slomo) 2015-11-18 17:18:03 UTC 
Attachment 315414 [details] pushed as 87b5ad0 - mpdparser: Also allow '/' in RepresentationID