GNOME Bugzilla – Bug 757834
Provide a shortcuts window
Last modified: 2017-12-27 12:37:38 UTC
Since Bijiben doesn't have a menu bar, it would be great to provide a GtkShortcutsWindow so that users can discover available keyboard shortcuts. More details can be found here: https://wiki.gnome.org/Initiatives/GnomeGoals/ShortcutWindows
The following shortcuts are now available: General: F1 = help Ctrl + q: Quit the application Alt + Left Arrow: Move to last view (have issues, may not be good to include) Ctrl + W: Same as above Ctrl + N: New note Selection mode: Escape: Cancel selection mode Ctrl + A: Select all Note Edit mode: Ctrl + b: toggle bold property of selected text Ctrl + i: toggle italic property of selected text Ctrl + s: toggle strike through property of the selected text Ctrl + z: undo Ctrl + Shift + z: redo Ctrl + Delete: Move to trash
Created attachment 364041 [details] [review] Add a shortcuts window
Review of attachment 364041 [details] [review]: Hi. I was vague when I wrote this. I assumed the author of the code would do it right. So you may replace those text with better smaller ones. The text provided corresponding to shortcuts may note be good enough. Say for example "toggle strike through property of the selected text" is really long (and may be much more longer in translations). You may use smaller text if possible. Would "toggle strike through" be good? How about "Move note to trash"? You may also add Ctrl+F1/Ctrl+? that will open shortcuts window. You will also have to add the file in po/POTFILES.in for the translations to happen really. Thanks
Hi Jonathan, thanks for your patch. Besides all the stuff that Sadiq already reviewed, would you please write a better commit message? That will improve our code base and git follow up. Nice work so far, thanks!
(In reply to Mohammed Sadiq from comment #3) > > The text provided corresponding to shortcuts may note be good enough. Say > for example "toggle strike through property of the selected text" is really > long (and may be much more longer in translations). You may use smaller text > if possible. Would "toggle strike through" be good? I just used LibreOffice and the tooltip for that button is simply "Strikethrough". So maybe we can simply use "Bold", "Italic" and "Strikethrough"? > > How about "Move note to trash"? Or to be precise, "Move current note to trash"? > > You may also add Ctrl+F1/Ctrl+? that will open shortcuts window. Sure. > > You will also have to add the file in po/POTFILES.in for the translations to > happen really. Ahh. I thought that file is not needed anymore after porting to meson, which is apparently not right. (In reply to Isaque Galdino from comment #4) > Hi Jonathan, thanks for your patch. Besides all the stuff that Sadiq already > reviewed, would you please write a better commit message? > Will do.
Created attachment 364985 [details] [review] Add a shortcuts window Patch updated.
Review of attachment 364985 [details] [review]: Hi Jonathan, thanks for your patch, but still it doesn't apply: error: patch failed: po/POTFILES.in:6 error: po/POTFILES.in: patch does not apply
Created attachment 366001 [details] [review] Add a shortcuts window patch rebased
Review of attachment 366001 [details] [review]: Thanks for you patch.