After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757703 - test-cleanup and test-reuse are not disabled --disable-tests
test-cleanup and test-reuse are not disabled --disable-tests
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
1.6.1
Other Linux
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-06 18:58 UTC by Joel Holdsworth
Modified: 2017-12-06 20:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (646 bytes, patch)
2015-11-06 18:58 UTC, Joel Holdsworth 		reviewed Details | Review

Description Joel Holdsworth 2015-11-06 18:58:44 UTC 
Created attachment 315012 [details] [review]
Patch

In tests/Makefile.am, test-cleanup and test-reuse are not disabled by --disable-tests. This patch fixes this.
Comment 1 Tim-Philipp Müller 2015-11-18 09:09:26 UTC 
Thanks for the patch!

I'd go one step further, and modify the top-level Makefile.am so that it never goes into tests/ in the first place (like it does for BUILD_EXAMPLES). Then we can also drop the check subdir special-casing in tests/Makefile.am

Any chance you could update the patch for that?
Comment 2 Tim-Philipp Müller 2017-12-06 20:48:54 UTC 
commit f5b7f57a1764820b312cb16cb24aa36f1db0ec33 (HEAD -> master, origin/master, origin/HEAD)
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Wed Dec 6 20:47:22 2017 +0000

    tests: disable all tests when --disable-tests is used
    
    Move conditional subdir include into top level.
    
    Based on patch by: Joel Holdsworth
    
    https://bugzilla.gnome.org/show_bug.cgi?id=757703