After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757693 - Invalid free in g_local_file_trash()
Invalid free in g_local_file_trash()
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.47.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
: 757192 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-11-06 16:42 UTC by Sebastien Bacher
Modified: 2015-11-17 17:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
that should fix the issue (659 bytes, patch)
2015-11-06 16:45 UTC, Sebastien Bacher 		committed Details | Review

Description Sebastien Bacher 2015-11-06 16:42:43 UTC 
The issue has been introduced with that commit
https://git.gnome.org/browse/glib/commit/gio/glocalfile.c?id=8ece2de964c01b3428f16766f199b58f0bc67212

the "topdir" variable was freed in an error block or at the end of the function, the free was moved earlier but the error block one is no needed anymore and leads to a segfault when trying to delete a .trash from a device in nautilus as described on https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1512826

The following patch should fix the issue
Comment 1 Sebastien Bacher 2015-11-06 16:45:33 UTC 
Created attachment 315005 [details] [review]
that should fix the issue
Comment 2 Sebastien Bacher 2015-11-17 17:11:01 UTC 
*** Bug 757192 has been marked as a duplicate of this bug. ***