After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757512 - Certain actions can't have shortcuts
Certain actions can't have shortcuts
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: Keybindings
git master
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-03 08:10 UTC by Egmont Koblinger
Modified: 2015-11-03 21:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix (4.36 KB, patch)
2015-11-03 21:23 UTC, Egmont Koblinger 		accepted-commit_now Details | Review

Description Egmont Koblinger 2015-11-03 08:10:46 UTC 
Preferences -> Shortcuts

Select All, Read Only, and probably a few others are missing, so you can't assign shortcuts to these actions.
Comment 1 Egmont Koblinger 2015-11-03 21:23:51 UTC 
Created attachment 314769 [details] [review]
Fix

Christian, please take a look.

It works for me, but I might have easily missed something as I'm not familiar with this part of the code at all, and it seems to be complicated, carrying legacy stuff and whatnot.
Comment 2 Christian Persch 2015-11-03 21:41:15 UTC 
Comment on attachment 314769 [details] [review]
Fix

Looks good.
Comment 3 Egmont Koblinger 2015-11-03 21:46:08 UTC 
Okay, submitted.