GNOME Bugzilla – Bug 757498
Fix compilation with ffmpeg 2.9
Last modified: 2016-01-16 15:26:36 UTC
A patch is included in the Debian bug report: https://bugs.debian.org/803822 Needs to be reviewed and possibly fixed up.
Created attachment 314853 [details] [review] avdeinterlace: Port non-deprecated AVFilter API
Created attachment 314854 [details] [review] avviddec: Stop using CODEC_FLAG_EMU_EDGE and avcodec_get_edge_width() It's deprecated now and not needed anymore: https://anonscm.debian.org/cgit/pkg-multimedia/ffmpeg.git/tree/doc/APIchanges#n558
Created attachment 314855 [details] [review] libav: Remove usage of deprecated API
This is also all relevant for 2.8 already, just that it still compiles without then.
(In reply to Sebastian Dröge (slomo) from comment #2) > Created attachment 314854 [details] [review] [review] > avviddec: Stop using CODEC_FLAG_EMU_EDGE and avcodec_get_edge_width() > > It's deprecated now and not needed anymore: > https://anonscm.debian.org/cgit/pkg-multimedia/ffmpeg.git/tree/doc/ > APIchanges#n558 This one should probably just remove the usage of GstVideoAlignment completely then?
Need more research imho, could have been replaced.
Comment on attachment 314855 [details] [review] libav: Remove usage of deprecated API This one seems fine
Nicolas, the edge API also gives deprecation warnings now. So I guess it's indeed unneeded nowadays.
Ok, one will need to check the new behaviour. Did they removed the left/top padding ? Note, we still need some video alignment code, so we keep some best effort negotiation of the stride (even if direct rendering is next to near impossible to obtain now). (note, I'm just giving feedback, I'll be back hacking next week)
I don't know yet, I just saw all the deprecation warnings during compilation and didn't look closer yet :)
Created attachment 319175 [details] [review] libav: Bitrate field changed from int to int64_t, fix compiler warnings
Created attachment 319176 [details] [review] avdeinterlace: Chain up to parent class' dispose()
Comment on attachment 314854 [details] [review] avviddec: Stop using CODEC_FLAG_EMU_EDGE and avcodec_get_edge_width() This one is not mergeable yet, it seems like EMU_EDGE is still used in some places in current master although it's marked as deprecated. It looks like it's going to be removed with API version 58, but master is still at 57.
Attachment 314853 [details] pushed as ddec3a2 - avdeinterlace: Port non-deprecated AVFilter API Attachment 314855 [details] pushed as 6235a04 - libav: Remove usage of deprecated API Attachment 319175 [details] pushed as 46fb2e9 - libav: Bitrate field changed from int to int64_t, fix compiler warnings Attachment 319176 [details] pushed as e04bcf0 - avdeinterlace: Chain up to parent class' dispose()
This now builds with 2.8 and git master.