After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757432 - [review] lr/vpn-aliases: Add support for VPN service name aliases
[review] lr/vpn-aliases: Add support for VPN service name aliases
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: VPN (general)
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2015-11-01 13:19 UTC by Lubomir Rintel
Modified: 2015-11-02 15:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Lubomir Rintel 2015-11-01 13:19:23 UTC 
Makes it possible to rename the openswan plugin while keeping compatibility (and allows for possible better IPsec plugin interoperability in future).

e53aa84 vpn-plugin-info: add vpn plugin service aliases
030a385 nm-glib: add g_strv_contains()
dc30542 vpn-plugin-info: drop nm_vpn_plugin_info_get_service()

http://cgit.freedesktop.org/NetworkManager/NetworkManager/log/?h=lr/vpn-aliases
Comment 1 Beniamino Galvani 2015-11-02 08:26:40 UTC 
Looks good.
Comment 2 Thomas Haller 2015-11-02 14:02:35 UTC 
>> nm-glib: add g_strv_contains()

There is already _nm_utils_strv_find_first() which also
 - works with non-NULL terminated arrays
 - is save against various edge cases
   e.g. _nm_utils_strv_find_first(NULL, -1, "needle") works as expected.
 - returns the index, thus being more generally useful.


Rest LGTM
Comment 3 Lubomir Rintel 2015-11-02 15:05:10 UTC 
afa6271 merge: branch 'lr/vpn-aliases'
cde053c vpn-plugin-info: add vpn plugin service aliases
3517084 vpn-plugin-info: drop nm_vpn_plugin_info_get_service()