After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757336 - adaptivedemux: reset download_finished before starting the src element
adaptivedemux: reset download_finished before starting the src element
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-29 23:41 UTC by Florin Apostol
Modified: 2015-10-30 11:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (2.57 KB, patch)
2015-10-29 23:42 UTC, Florin Apostol 		committed Details | Review

Description Florin Apostol 2015-10-29 23:41:19 UTC 
The src element might post multiple errors on adaptive demux pipeline. When getting error messages, adaptive demux will call gst_adaptive_demux_stream_fragment_download_finish which will set download_finished to TRUE. This means that if a second error message is received, the download_finished will be set a second time, causing the next download to be considered "finished". The gst_adaptive_demux_stream_download_uri function will fail to wait for this download.

The solution is to reset the download_finished while the src element is in ready state, right before adaptive demux will put it in playing state.
Comment 1 Florin Apostol 2015-10-29 23:42:29 UTC 
Created attachment 314431 [details] [review]
proposed patch
Comment 2 Florin Apostol 2015-10-30 11:14:01 UTC 
Vincent, can you please review and merge this?
Comment 3 Vincent Penquerc'h 2015-10-30 11:44:08 UTC 
commit e29514ea3dbd1e815bb63ef4808c8eeed48da0b7
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Thu Oct 29 23:41:46 2015 +0000

    adaptivedemux: reset download_finished before starting the src element
    
    https://bugzilla.gnome.org/show_bug.cgi?id=757336