Created attachment 314389 [details] [review]
placesview: vertically align path labels

The current situation is somewhat sad, with the path
label totally misaligned throughout the rows.

This is fixed by using a size group for the path labels,
so they all have the same allocated size (with the max
of 15 chars). Also, instead of hiding the eject button,
set it child-invisible, so it is hidden and yet it's size
is allocated by GtkBox.
(

Review of attachment 314389 [details] [review]:

::: gtk/gtkplacesview.c
@@ +73,3 @@
   GtkWidget                     *network_placeholder_label;
 
+  GtkSizeGroup                  *size_group;

Might be good to give a more meaningful name, like path_size_group ?

::: gtk/gtkplacesviewrow.c
@@ +151,3 @@
     case PROP_MOUNT:
       g_set_object (&self->mount, g_value_get_object (value));
+      gtk_widget_set_child_visible (GTK_WIDGET (self->eject_button), self->mount != NULL);

This use of child visible here seems a bit unconventional and fragile.
At the very least, it needs a comment explaining what is going on.

@@ +327,3 @@
+void
+gtk_places_view_row_set_size_group (GtkPlacesViewRow *row,
+                                    GtkSizeGroup     *group)

...and reflect that here too then: gtk_places_view_row_set_path_size_group

Created attachment 314394 [details] [review]
placesview: vertically align path labels

Added a comment and updated function and var names.

Review of attachment 314394 [details] [review]:

thanks for making those changes. the use of child-visible seems iffy, still

Attachment 314394 [details] pushed as 50c6a11 - placesview: vertically align path labels