After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757298 - nautilus crashes on drag'n'drop over 'side bar'
nautilus crashes on drag'n'drop over 'side bar'
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Crashers
3.16.x
Other Linux
: Normal normal
: 3.18
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 756303 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-10-29 12:01 UTC by Dominique Leuenberger
Modified: 2015-11-02 14:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not crash if uris is NULL (801 bytes, patch)
2015-10-29 12:59 UTC, Dominique Leuenberger 		none Details | Review
Fixed typo in the commit message (802 bytes, patch)
2015-10-29 15:38 UTC, Dominique Leuenberger 		accepted-commit_now Details | Review

Description Dominique Leuenberger 2015-10-29 12:01:18 UTC 
Setup:

GNOME (3.16.x) running inside a VirtualBox (I will try to validate in the next 24 hours if 3.18.x still exposes it) as guest

VirtualBox version 5.0.6

On dragging a file from the HOST to the GUEST, nautilus segfaults IF the drag'n'drop actions happens to over over the left sidebar.

Drag'n'Drop action works fine if you never touch the sidebar
Comment 1 Dominique Leuenberger 2015-10-29 12:01:40 UTC 
(gdb) bt

+ Trace 235648

  • #0 build_file_list_from_uris
    at gtkplacessidebar.c line 1886
  • #1 drag_data_received_callback
    at gtkplacessidebar.c line 1977
  • #2 _gtk_marshal_VOID__OBJECT_INT_INT_BOXED_UINT_UINT
    at gtkmarshalers.c line 5524
  • #3 g_closure_invoke
    at gclosure.c line 768
  • #4 signal_emit_unlocked_R
    at gsignal.c line 3549
  • #5 g_signal_emit_valist
    at gsignal.c line 3305
  • #6 g_signal_emit_by_name
    at gsignal.c line 3401
  • #7 gtk_drag_selection_received
    at gtkdnd.c line 1844
  • #8 g_closure_invoke
    at gclosure.c line 768
  • #9 signal_emit_unlocked_R
    at gsignal.c line 3549
  • #10 g_signal_emit_valist
    at gsignal.c line 3305
  • #11 g_signal_emit_by_name
    at gsignal.c line 3401
  • #12 gtk_selection_retrieval_report
    at gtkselection.c line 3023
  • #13 _gtk_selection_notify
    at gtkselection.c line 2802
  • #14 _gtk_marshal_BOOLEAN__BOXEDv
    at gtkmarshalers.c line 130
  • #15 _g_closure_invoke_va
    at gclosure.c line 831
  • #16 g_signal_emit_valist
    at gsignal.c line 3214
  • #17 g_signal_emit
  • #18 gtk_widget_event_internal
    at gtkwidget.c line 7787
  • #19 gtk_main_do_event
    at gtkmain.c line 1698
  • #20 gdk_event_source_dispatch
    at gdkeventsource.c line 364
  • #21 g_main_dispatch
    at gmain.c line 3122
  • #22 g_main_context_dispatch
    at gmain.c line 3737
  • #23 g_main_context_iterate
    at gmain.c line 3808
  • #24 g_main_context_iteration
    at gmain.c line 3869
  • #25 g_application_run
    at gapplication.c line 2308
  • #26 main
    at nautilus-main.c line 103 






Comment 2


Dominique Leuenberger





          2015-10-29 12:59:02 UTC
        



Created attachment 314392 [details] [review]
Do not crash if uris is NULL

Looking at the code, MASTER is still affected.

This patch has been tested on my 3.16.x system and successfully resolved the crash for me.






Comment 3


Dominique Leuenberger





          2015-10-29 15:38:26 UTC
        



Created attachment 314412 [details] [review]
Fixed typo in the commit message






Comment 4


Carlos Soriano





          2015-10-29 16:28:51 UTC
        



Review of attachment 314412 [details] [review]:

Looks good to me thanks!

Do you have commits rights? If so, can you push it to master and 3.18 and 3.16?






Comment 6


Sebastien Bacher





          2015-11-02 14:16:42 UTC
        



*** Bug 756303 has been marked as a duplicate of this bug. ***