After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757251 - ivfparse: recognize the vp9 bitstream
ivfparse: recognize the vp9 bitstream
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.6.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-28 13:05 UTC by sreerenj
Modified: 2015-10-29 13:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add vp9 support (2.50 KB, patch)
2015-10-28 13:05 UTC, sreerenj 		none Details | Review
ivfparse: add vp9 support (2.48 KB, patch)
2015-10-29 13:05 UTC, sreerenj 		committed Details | Review

Description sreerenj 2015-10-28 13:05:35 UTC 
Created attachment 314322 [details] [review]
add vp9 support

Add vp9 support in ivfparse
Comment 1 Tim-Philipp Müller 2015-10-29 11:10:16 UTC 
Comment on attachment 314322 [details] [review]
add vp9 support

Thanks, looks good, just two nitpicks:

- terminology: please change *mime_type to *media_type (GStreamer uses GStreamer media types)

- the check in gst_ivf_parse_handle_frame_start() could be simplified by calling fourcc_to_mime_type() and checking if it returns NULL (also more future proof)
Comment 2 sreerenj 2015-10-29 13:05:37 UTC 
Created attachment 314393 [details] [review]
ivfparse: add vp9 support
Comment 3 Tim-Philipp Müller 2015-10-29 13:29:11 UTC 
Thanks!

commit d7a167c5b4e4aee7078119e8c963abaf1a29111b
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Thu Oct 29 15:02:38 2015 +0200

    ivfparse: Add vp9 support
    
    Differentiate the vp8/vp9 bitstream based on fourcc.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=757251