After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757045 - tracer: Emit 'element-new' hook when using parse_launch
tracer: Emit 'element-new' hook when using parse_launch
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-24 08:57 UTC by Thibault Saunier
Modified: 2015-10-29 10:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tracer: Emit 'element-new' hook when using parse_launch (841 bytes, patch)
2015-10-24 08:57 UTC, Thibault Saunier 		reviewed Details | Review
element: emit tracer's element-new hook from 'constructed' (2.04 KB, patch)
2015-10-28 20:36 UTC, Thiago Sousa Santos 		committed Details | Review

Description Thibault Saunier 2015-10-24 08:57:15 UTC 
Otherwise we will miss that info
Comment 1 Thibault Saunier 2015-10-24 08:57:20 UTC 
Created attachment 314001 [details] [review]
tracer: Emit 'element-new' hook when using parse_launch
Comment 2 Sebastian Dröge (slomo) 2015-10-24 09:45:05 UTC 
Comment on attachment 314001 [details] [review]
tracer: Emit 'element-new' hook when using parse_launch

Shouldn't that hook be emitted by something else then? Like GstElement's GObject::constructed() vfunc?

We otherwise also miss elements that have no factory and are created by g_object_new() with the GType.
Comment 3 Thiago Sousa Santos 2015-10-28 20:36:20 UTC 
Created attachment 314341 [details] [review]
element: emit tracer's element-new hook from 'constructed'

Was also in need with this so here's the patch I'm using
Comment 4 Thibault Saunier 2015-10-29 08:51:16 UTC 
Review of attachment 314341 [details] [review]:

I should have proposed my new version of that patch, anyway thanks :)
Comment 5 Thiago Sousa Santos 2015-10-29 10:38:15 UTC 
commit 973cd86c99fadf3583ba0b27e5c785f1dc3c5860
Author: Thiago Santos <thiagoss@osg.samsung.com>
Date:   Wed Oct 28 17:31:07 2015 -0300

    element: emit tracer's element-new hook from 'constructed'
    
    It allows to properly emitting it for all newly created elements
    
    https://bugzilla.gnome.org/show_bug.cgi?id=757045