After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756925 - Moving mouse to the hot corner and clicking in the same moment shows overview briefly
Moving mouse to the hot corner and clicking in the same moment shows overview...
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-10-21 19:46 UTC by Марко Костић (Marko Kostić)
Modified: 2015-10-23 11:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ActivitiesButton: fix overview being toggled while still animating (1.36 KB, patch)
2015-10-22 16:17 UTC, Rui Matos
committed Details | Review

Description Марко Костић (Marko Kostić) 2015-10-21 19:46:05 UTC
If I move mouse to the hot corner AND click with the mouse at the same, Gnome Shell will show Overview briefly and then quickly show the desktop. A lot of people I've met, when presented with the Gnome 3 for the first time, do something similar to this and then experience this behaviour. That's very confusing for them.

Could GS negate the mouse click if it happened in less than 500 ms (totally made up value) since the last time hot corner was activated? That would solve a problem where people want to click on Activities and then accidentally click AND activate hot corner which triggers Overview and then promptly returns them to the Desktop, leaving them very confused.
Comment 1 Марко Костић (Marko Kostić) 2015-10-21 19:47:31 UTC
[..]AND click with the mouse at the same moment*
Comment 2 Rui Matos 2015-10-22 16:17:09 UTC
Created attachment 313871 [details] [review]
ActivitiesButton: fix overview being toggled while still animating

Adds the missing checks for whether we should toggle the overview, on
button and key release.
Comment 3 Florian Müllner 2015-10-22 16:26:23 UTC
Review of attachment 313871 [details] [review]:

::: js/ui/panel.js
@@ +460,3 @@
         if (event.type() == Clutter.EventType.TOUCH_END ||
             event.type() == Clutter.EventType.BUTTON_RELEASE)
+            if (Main.overview.shouldToggleByCornerOrButton())

Could && the condition instead of using nested ifs
Comment 4 Rui Matos 2015-10-23 11:47:39 UTC
Attachment 313871 [details] pushed as 0c72d1f - ActivitiesButton: fix overview being toggled while still animating