After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756886 - The GtkWindow patch here is necessary to make transparent terminals work under
The GtkWindow patch here is necessary to make transparent terminals work under
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-10-20 20:54 UTC by Owen Taylor
Modified: 2015-10-22 15:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GtkWindow: draw the frame and shadow even for app-paintable windows (3.32 KB, patch)
2015-10-20 20:54 UTC, Owen Taylor
committed Details | Review
testgtk/Alpha Window: fix the drawn area when we are drawing decorations (1.54 KB, patch)
2015-10-20 20:54 UTC, Owen Taylor
committed Details | Review

Description Owen Taylor 2015-10-20 20:54:14 UTC
Wayland - see https://bugzilla.redhat.com/show_bug.cgi?id=1207943.

(I also had to work around another bug in GTK+ where 

 gtk_widget_set_app_paintable(window)

doesn't update the opaque region of the window until the next paint. Maybe we
should make gtk_widget_set_app_paintable() queue a resize, though other widgets
than GtkWindow won't need that - it's not like app-paintable is usually changed
on the fly.)
Comment 1 Owen Taylor 2015-10-20 20:54:19 UTC
Created attachment 313775 [details] [review]
GtkWindow: draw the frame and shadow even for app-paintable windows

If a window is decorated, we need to draw the frame and shadow, even if
it is app-paintable - it's just nonsense to have a frame that we handle
events on, but expect the app to paint it. (We paint the titlebar in
any case.) If a client wants to handle all painting, it should use an
undecorated window.
Comment 2 Owen Taylor 2015-10-20 20:54:25 UTC
Created attachment 313776 [details] [review]
testgtk/Alpha Window: fix the drawn area when we are drawing decorations

A GtkWindow's allocation includes the titlebar, borders, and shadows; we
only want to draw our custom alpha content over the child allocation of
the GtkWindow.
Comment 3 Matthias Clasen 2015-10-22 01:22:01 UTC
Review of attachment 313775 [details] [review]:

makes sense
Comment 4 Matthias Clasen 2015-10-22 01:36:01 UTC
Review of attachment 313776 [details] [review]:

sure
Comment 5 Owen Taylor 2015-10-22 15:09:08 UTC
Pushed to master and gtk-3-18

Attachment 313775 [details] pushed as e29b911 - GtkWindow: draw the frame and shadow even for app-paintable windows
Attachment 313776 [details] pushed as 390c111 - testgtk/Alpha Window: fix the drawn area when we are drawing decorations