After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756641 - rtpbuffer: increase logging level when map fails
rtpbuffer: increase logging level when map fails
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.6.0
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-15 13:36 UTC by Miguel París Díaz
Modified: 2015-10-15 19:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtpbuffer: increase logging level when map fails (1.32 KB, patch)
2015-10-15 13:36 UTC, Miguel París Díaz 		rejected Details | Review

Description Miguel París Díaz 2015-10-15 13:36:00 UTC 
Created attachment 313370 [details] [review]
rtpbuffer: increase logging level when map fails

I think that it is important to log as WARNING messages when mapping an RtpBuffer fails.
Comment 1 Sebastian Dröge (slomo) 2015-10-15 13:50:03 UTC 
commit e3c8a820176ba39dfae85944fa9c6ae202ec681d
Author: Miguel París Díaz <mparisdiaz@gmail.com>
Date:   Thu Oct 15 15:32:58 2015 +0200

    rtpbuffer: increase logging level when map fails
    
    https://bugzilla.gnome.org/show_bug.cgi?id=756641
Comment 2 Tim-Philipp Müller 2015-10-15 14:04:14 UTC 
(Note that this allows outsiders to spam your log by sending invalid packets if you log this, so there's a trade-off here.)
Comment 3 Miguel París Díaz 2015-10-15 15:03:39 UTC 
You are right.
Moreover, map function is used by some elements to verify if a buffer is RTP or RTCP, so this warning appears too often.
So, we could revert the patch.
Sorry for the noise :S.