After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756582 - please drop shebang from bash completion file
please drop shebang from bash completion file
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: shell
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-14 17:40 UTC by Michael Biebl
Modified: 2018-01-21 13:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] Drop shebang from bash completion (702 bytes, patch)
2015-10-14 17:40 UTC, Michael Biebl 		none Details | Review
completion: Drop shebang (973 bytes, patch)
2018-01-21 13:37 UTC, Georges Basile Stavracas Neto 		committed Details | Review

Description Michael Biebl 2015-10-14 17:40:11 UTC 
Those completion files are meant to be sourced, not executed directly.
Comment 1 Michael Biebl 2015-10-14 17:40:37 UTC 
Created attachment 313317 [details] [review]
[PATCH] Drop shebang from bash completion
Comment 2 Bastien Nocera 2015-10-14 20:04:30 UTC 
Review of attachment 313317 [details] [review]:

Why not keep it though? What difference does it make?
Comment 3 Michael Biebl 2015-10-14 20:10:57 UTC 
just following best practice here.
No other bash completion file has a shebang (as said, those are meant to be sourced) and our automated test tool lintian keeps flagging /usr/share/bash-completion/completions/gnome-control-center, so it seemed reasonable to fix that for good upstream.
Comment 4 Bastien Nocera 2015-10-14 23:25:34 UTC 
(In reply to Michael Biebl from comment #3)
> just following best practice here.
> No other bash completion file has a shebang (as said, those are meant to be
> sourced) and our automated test tool lintian keeps flagging
> /usr/share/bash-completion/completions/gnome-control-center, so it seemed
> reasonable to fix that for good upstream.

Would be good to mention that in the commit message in the first place :)
Comment 5 Bastien Nocera 2016-10-17 12:21:41 UTC 
Waiting on an updated patch.
Comment 6 Georges Basile Stavracas Neto 2018-01-21 13:37:27 UTC 
Created attachment 367171 [details] [review]
completion: Drop shebang

Updating the commit message.
Comment 7 Georges Basile Stavracas Neto 2018-01-21 13:38:11 UTC 
Thanks for the patch. Closing the bug.

Attachment 367171 [details] pushed as 385cd85 - completion: Drop shebang