After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756510 - icon-utils: Don't pass a 'void *' where an 'int' is expected
icon-utils: Don't pass a 'void *' where an 'int' is expected
Status: RESOLVED FIXED
Product: libgd
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: libgd maintainer(s)
libgd maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-10-13 15:31 UTC by Debarshi Ray
Modified: 2015-10-23 07:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
icon-utils: Don't pass a 'void *' where an 'int' is expected (961 bytes, patch)
2015-10-13 15:32 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2015-10-13 15:31:37 UTC
Commit 1e049c22660d70132a3735d61d7a7daa957b59fc introduced this warning:

libgd/gd-icon-utils.c: In function 'gd_embed_image_in_frame':
libgd/gd-icon-utils.c:211:51: warning: passing argument 2 of 'gdk_cairo_surface_create_from_pixbuf' makes integer from pointer without a cast
                                                   NULL, NULL);
                                                   ^
In file included from /opt/include/gtk-3.0/gdk/gdk.h:33:0,
                 from /opt/include/gtk-3.0/gtk/gtk.h:30,
                 from libgd/gd-icon-utils.h:25,
                 from libgd/gd-icon-utils.c:22:
/opt/include/gtk-3.0/gdk/gdkcairo.h:70:19: note: expected 'int' but argument is of type 'void *'
 cairo_surface_t * gdk_cairo_surface_create_from_pixbuf      (const GdkPixbuf *pixbuf,
                   ^
Comment 1 Debarshi Ray 2015-10-13 15:32:46 UTC
Created attachment 313197 [details] [review]
icon-utils: Don't pass a 'void *' where an 'int' is expected
Comment 2 Debarshi Ray 2015-10-23 07:40:31 UTC
Comment on attachment 313197 [details] [review]
icon-utils: Don't pass a 'void *' where an 'int' is expected

I think this is fine, and I am tired of the warnings. Pushed to master.