After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756235 - build: Fix GIR namespace version
build: Fix GIR namespace version
Status: RESOLVED FIXED
Product: gcr
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-10-08 09:54 UTC by Philip Withnall
Modified: 2019-02-22 11:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Fix GIR namespace version (1.29 KB, patch)
2015-10-08 09:54 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2015-10-08 09:54:02 UTC 
Trivial patch attached.
Comment 1 Philip Withnall 2015-10-08 09:54:05 UTC 
Created attachment 312898 [details] [review]
build: Fix GIR namespace version

Unless --nsversion is passed to g-ir-scanner, it will extract the
namespace version for a GIR file from the filename. Unfortunately, for
the Gcr-3.broken.gir file, this means it extracts ‘3.broken’. This is
incorrect, and doesn’t match the version in the typelib (which is the
correct ‘3’).

Having mismatched versions can cause problems when loading the GIR
files, as libgirepository complains that they don’t match the typelib.
Comment 2 Stef Walter 2015-10-08 10:40:05 UTC 
Review of attachment 312898 [details] [review]:

Looks good to me.
Comment 3 Philip Withnall 2015-10-08 11:26:05 UTC 
Attachment 312898 [details] pushed as c325550 - build: Fix GIR namespace version