After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756226 - qtdemux: fix memory leak for corrupted file
qtdemux: fix memory leak for corrupted file
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-08 05:43 UTC by Vineeth
Modified: 2015-10-08 14:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix memory leak (966 bytes, patch)
2015-10-08 05:44 UTC, Vineeth
committed Details | Review

Description Vineeth 2015-10-08 05:43:59 UTC
While checking a corrupted file using valgrind, there is a memory leak.

==28386== 255 (160 direct, 95 indirect) bytes in 1 blocks are definitely lost in loss record 3,880 of 3,991
==28386==    at 0x402C17C: malloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==28386==    by 0x4259BE2: g_malloc (in /lib/i386-linux-gnu/libglib-2.0.so.0.4002.0)
==28386==    by 0x4270281: g_slice_alloc (in /lib/i386-linux-gnu/libglib-2.0.so.0.4002.0)
==28386==    by 0x40A7E6B: gst_buffer_new (gstbuffer.c:714)
==28386==    by 0x40A8FB4: gst_buffer_new_allocate (gstbuffer.c:762)
==28386==    by 0x6D53894: qtdemux_parse_ftyp.part.34 (qtdemux.c:2381)
==28386==    by 0x6D70B33: gst_qtdemux_loop_state_header (qtdemux.c:3769)
==28386==    by 0x6D75090: gst_qtdemux_loop (qtdemux.c:5254)
==28386==    by 0x4118888: gst_task_func (gsttask.c:331)
==28386==    by 0x4119A2E: default_func (gsttaskpool.c:68)
==28386==    by 0x427B404: ??? (in /lib/i386-linux-gnu/libglib-2.0.so.0.4002.0)
==28386==    by 0x427A9A9: ??? (in /lib/i386-linux-gnu/libglib-2.0.so.0.4002.0)
==28386==    by 0x431FF6F: start_thread (pthread_create.c:312)
==28386==    by 0x4421BED: clone (clone.S:129)
Comment 1 Vineeth 2015-10-08 05:44:50 UTC
Created attachment 312883 [details] [review]
fix memory leak
Comment 2 Sebastian Dröge (slomo) 2015-10-08 14:04:37 UTC
Comment on attachment 312883 [details] [review]
fix memory leak

commit b26ce7ba6de38f4339648be5c8c068d67fa96c6e
Author: Vineeth TM <vineeth.tm@samsung.com>
Date:   Thu Oct 8 14:44:07 2015 +0900

    qtdemux: Fix memory leak for corrupted file
    
    Free brands before overriding them.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=756226