After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756011 - Fix up annotations for GBookmarkFile
Fix up annotations for GBookmarkFile
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: introspection
unspecified
Other All
: Normal minor
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-10-03 09:53 UTC by Mikhail Zabaluev
Modified: 2018-01-08 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gbookmarkfile: fix up annotations (9.85 KB, patch)
2015-10-03 09:53 UTC, Mikhail Zabaluev 		none Details | Review
Annotate g_bookmark_file_new() as a constructor (747 bytes, patch)
2015-10-04 16:11 UTC, Mikhail Zabaluev 		committed Details | Review
gbookmarkfile: fix up annotations (3.40 KB, patch)
2018-01-05 20:21 UTC, Mikhail Zabaluev 		none Details | Review
gbookmarkfile: fix up annotations (2.24 KB, patch)
2018-01-05 23:09 UTC, Mikhail Zabaluev 		committed Details | Review

Description Mikhail Zabaluev 2015-10-03 09:53:01 UTC 
- Array annotations for byte array data
- Filename annotations for pathname values
- Add (nullable) where missing
- Fix a few odds and ends
- Replace (allow-none)
Comment 1 Mikhail Zabaluev 2015-10-03 09:53:06 UTC 
Created attachment 312597 [details] [review]
gbookmarkfile: fix up annotations
Comment 2 Mikhail Zabaluev 2015-10-04 16:11:53 UTC 
Created attachment 312642 [details] [review]
Annotate g_bookmark_file_new() as a constructor
Comment 3 Philip Withnall 2017-09-11 20:00:19 UTC 
Review of attachment 312597 [details] [review]:

Needs rebasing.

::: glib/gbookmarkfile.c
@@ +1767,3 @@
  * @bookmark: a #GBookmarkFile
+ * @file: (type filename): a relative path to a filename to open and parse
+ * @full_path: (out) (optional) (type filename): return location for a string

Also needs (transfer full), I think.
Comment 4 Philip Withnall 2017-09-11 20:00:58 UTC 
Review of attachment 312642 [details] [review]:

++
Comment 5 Philip Withnall 2017-09-11 20:02:07 UTC 
Comment on attachment 312642 [details] [review]
Annotate g_bookmark_file_new() as a constructor

Attachment 312642 [details] pushed as 3ee5bb1 - Annotate g_bookmark_file_new() as a constructor
Comment 6 Mikhail Zabaluev 2018-01-05 20:21:54 UTC 
Created attachment 366397 [details] [review]
gbookmarkfile: fix up annotations
Comment 7 Philip Withnall 2018-01-05 20:29:35 UTC 
Review of attachment 366397 [details] [review]:

Thanks for the update. A few small issues.

::: glib/gbookmarkfile.c
@@ +2223,3 @@
  * @error is set to #G_BOOKMARK_FILE_ERROR_URI_NOT_FOUND.
  *
+ * Returns: (nullable): a newly allocated string or %NULL if the specified

(nullable) is not correct here, as NULL is only returned on the error path. (nullable) is needed only if NULL may be returned on success.

@@ +2305,3 @@
  * @error is set to #G_BOOKMARK_FILE_ERROR_INVALID_VALUE.
  *
+ * Returns: (nullable): a newly allocated string or %NULL if the specified

Same here.
Comment 8 Mikhail Zabaluev 2018-01-05 23:09:14 UTC 
Created attachment 366400 [details] [review]
gbookmarkfile: fix up annotations
Comment 9 Philip Withnall 2018-01-05 23:39:50 UTC 
Review of attachment 366400 [details] [review]:

Thanks.
Comment 10 Mikhail Zabaluev 2018-01-08 18:24:43 UTC 
Thank you. My commit access has been revoked due to inactivity, please push attachment #366400 [details].
Comment 11 Philip Withnall 2018-01-08 18:27:03 UTC 
Pushed to master, thanks.

Attachment 366400 [details] pushed as ef65c16 - gbookmarkfile: fix up annotations