GNOME Bugzilla – Bug 755713
Use header bars in the printers panel
Last modified: 2017-02-28 17:13:35 UTC
This patchset cares for the jobs, options, and ppd selection dialogs. It does NOT fix the new printer dialog nor does it fix the Samba authentication dialog. The new printer dialog is a bit tricky and I don't have a Samba printer; help with those two dialogs would be great.
Created attachment 312255 [details] [review] printers: Use a header bar on the jobs dialog
Created attachment 312256 [details] [review] printers: Add tooltips for icon buttons on jobs dialog
Created attachment 312257 [details] [review] printers: Move options dialog spinner out of the action area For an infinitesimal amount of time after opening the options dialog, a spinner is displayed at the start of the action area while the dialog loads asynchronously. Display the spinner in the center of the dialog instead, using a GtkStack to switch between spinner mode and normal mode. Test by removing the calls to printer_get_ppd_async(), get_named_dest_async(), and get_ipp_attributes_async() from the bottom of populate_options(). Why? (1) It looks better this way. (2) Need to stop using the action area in order to switch to a header bar.
Created attachment 312258 [details] [review] printers: Use a header bar on the options dialog
Created attachment 312259 [details] [review] printers: Avoid warning about unparented ppd selection dialog Just need to call gtk_window_set_transient_for() a bit earlier.
Created attachment 312260 [details] [review] printers: Move ppd selection dialog spinner out of the action area
Created attachment 312261 [details] [review] printers: Use a header bar on the ppd selection dialog
Created attachment 312262 [details] [review] printers: Add mnemonics for ppd selection dialog actions
(In reply to Michael Catanzaro from comment #1) > Created attachment 312255 [details] [review] [review] > printers: Use a header bar on the jobs dialog Hi, this part is actually covered by redesign of the jobs dialog in #755626.
Review of attachment 312259 [details] [review]: Thank you for fixing this. This can go to 3.16 as well.
Thank you for the patches. Have you consulted the UI changes with a Gnome designer (e.g. Allan Day)? I guess that at least the usage of header bar in options dialog should correspond to the redesign on https://wiki.gnome.org/Design/SystemSettings/Printers (except the "Test Page" button which should be added once the whole redesign is done) .
I obsoleted my Jobs dialog patches, since they'd conflict with Felipe's work, which we should use instead. (In reply to Marek Kašík from comment #11) > Thank you for the patches. Have you consulted the UI changes with a Gnome > designer (e.g. Allan Day)? I haven't consulted him on this in particular, but I could if you want me to. But it's just a standard application of his "move the buttons from the action area to the header bar" pattern that we've been applying all over the place. For an action dialog (the ppd selection dialog) the header bar has a Cancel button and a suggested action button; for presentation dialogs just a standard X close button (and in general, possibly a suggested action button, but not in any of these cases). > I guess that at least the usage of header bar in options dialog should > correspond to the redesign on > https://wiki.gnome.org/Design/SystemSettings/Printers (except the "Test > Page" button which should be added once the whole redesign is done) . The only difference I see regarding the header bar is that the word "Options" is appended to the title in the mockup. (And the Test Page button isn't there.)
(In reply to Michael Catanzaro from comment #12) > I obsoleted my Jobs dialog patches, since they'd conflict with Felipe's > work, which we should use instead. > > (In reply to Marek Kašík from comment #11) > > Thank you for the patches. Have you consulted the UI changes with a Gnome > > designer (e.g. Allan Day)? > > I haven't consulted him on this in particular, but I could if you want me > to. But it's just a standard application of his "move the buttons from the > action area to the header bar" pattern that we've been applying all over the > place. For an action dialog (the ppd selection dialog) the header bar has a > Cancel button and a suggested action button; for presentation dialogs just a > standard X close button (and in general, possibly a suggested action button, > but not in any of these cases). I would like to have the spinner changes reviewed by a designer. > > I guess that at least the usage of header bar in options dialog should > > correspond to the redesign on > > https://wiki.gnome.org/Design/SystemSettings/Printers (except the "Test > > Page" button which should be added once the whole redesign is done) . > > The only difference I see regarding the header bar is that the word > "Options" is appended to the title in the mockup. (And the Test Page button > isn't there.) There is also the separator on the right side of the header bar in the options dialog mock-up.
Also, sizes of the 2 dialogs are smaller than before. We should preserve them because there is quite a lot of information on them.
(In reply to Marek Kašík from comment #13) ... > > > Thank you for the patches. Have you consulted the UI changes with a Gnome > > > designer (e.g. Allan Day)? > > > > I haven't consulted him on this in particular, but I could if you want me > > to. But it's just a standard application of his "move the buttons from the > > action area to the header bar" pattern that we've been applying all over the > > place. For an action dialog (the ppd selection dialog) the header bar has a > > Cancel button and a suggested action button; for presentation dialogs just a > > standard X close button (and in general, possibly a suggested action button, > > but not in any of these cases). > > I would like to have the spinner changes reviewed by a designer. If someone wants to record a video of the new UI in action, I'd be happy to take a look. At the same time, I would hope that every small change doesn't need my approval - that won't scale (and it's why we have the Human Interface Guidelines).
I'll try to post screenshots soon. A video won't work since the spinner is shown and then hidden almost instantaneously; you wouldn't know it is there unless you hack the code to force it to display always.
(In reply to Marek Kašík from comment #13) > There is also the separator on the right side of the header bar in the > options dialog mock-up. It's a minor flaw in the mockup. The separator is there for main windows, not for dialogs. GTK+ handles that automatically.
(In reply to Marek Kašík from comment #14) > Also, sizes of the 2 dialogs are smaller than before. We should preserve > them because there is quite a lot of information on them. Indeed, not sure how I broke this.... I also accidentally lost the title on the ppd selection dialog. Need to fix that still. Anyway, attaching screenshots of the spinners, though they're pretty standard....
Created attachment 312871 [details] Options dialog
Created attachment 312872 [details] Options dialog (loading)
Created attachment 312873 [details] ppd selection dialog The missing title should be "Select printer driver"
Created attachment 312874 [details] ppd selection dialog spinner Erm, well this spinner is not where I thought I put it... I thought I had the text underneath the spinner. So sending me to get designer approval was a good idea. :p I will need to fix that.... Anyway, the text is optional.
Created attachment 312876 [details] [review] printers: Manual ppd selection dialog should have a parent
Review of attachment 312876 [details] [review]: Thank you for this patch. It looks good to me.
Sorry, I'm not sure when I'll get around to updating these patches. I don't know why they made the dialogs smaller.
Comment on attachment 312876 [details] [review] printers: Manual ppd selection dialog should have a parent (Pushing only the trivial patch that was accepted.) Attachment 312876 [details] pushed as 3496b05 - printers: Manual ppd selection dialog should have a parent
Created attachment 340795 [details] [review] printers: Move options dialog spinner out of the action area For an infinitesimal amount of time after opening the options dialog, a spinner is displayed at the start of the action area while the dialog loads asynchronously. Display the spinner in the center of the dialog instead, using a GtkStack to switch between spinner mode and normal mode. Test by removing the calls to printer_get_ppd_async(), get_named_dest_async(), and get_ipp_attributes_async() from the bottom of populate_options(). Why? (1) It looks better this way. (2) Need to stop using the action area in order to switch to a header bar.
(In reply to Felipe Borges from comment #27) > Created attachment 340795 [details] [review] [review] > printers: Move options dialog spinner out of the action area > I updated this patch in order to match the spinner which we already have in the main view while loading.
Hey Felipe, can this bug be closed now? I guess so. Please reopen if there's anything more here that you want.