After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755528 - Popover transitions are rather slow
Popover transitions are rather slow
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-09-24 10:42 UTC by Timm Bäder
Modified: 2015-09-30 01:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Set the popover transition duration to 0.2s (697 bytes, patch)
2015-09-24 10:42 UTC, Timm Bäder 		none Details | Review
GtkPopover: Make transitions faster (741 bytes, patch)
2015-09-29 16:25 UTC, Timm Bäder 		accepted-commit_now Details | Review

Description Timm Bäder 2015-09-24 10:42:06 UTC 
Created attachment 312035 [details] [review]
Set the popover transition duration to 0.2s

With 0.33 seconds, the popove show/hide transitions seem rather slow.
GtkStack has a default of 0.2s, GtkRevealer 0.25s, while gnome-shell even uses 0.15s for their popupMenus, so gtk+'s takes more than twice as long.

I don't know whether we should generally unify the default for transition durations or not, but since the popover one is modeled after the shell's, we could at least get closer to the 0.15s.

Attached is a patch that changes the duration to 0.2s.
Comment 1 Jakub Steiner 2015-09-29 09:41:57 UTC 
You shouldn't feel like you're waiting for the transition. Did the .15 feel choppy in gtk? Why not sync with the shell?
Comment 2 Timm Bäder 2015-09-29 11:00:20 UTC 
I picked 0.2 instead of 0.15 to be closer to the shell but also to just use the one from GtkStack. We can certainly do 0.15.

It's fast enough for me, if it is not for you, you might want to wait for bug https://bugzilla.gnome.org/show_bug.cgi?id=755435, or just apply those before changing the transition duration (I have them applied locally).
Comment 3 Timm Bäder 2015-09-29 16:25:27 UTC 
Created attachment 312367 [details] [review]
GtkPopover: Make transitions faster
Comment 4 Timm Bäder 2015-09-29 16:26:29 UTC 
Bug 755435 has been merged. The new patch uses .15s and the performance is no problem on my system.
Comment 5 Matthias Clasen 2015-09-30 01:12:47 UTC 
Review of attachment 312367 [details] [review]:

Looks fine to me
Comment 6 Matthias Clasen 2015-09-30 01:13:11 UTC 
Review of attachment 312367 [details] [review]:

.
Comment 7 Matthias Clasen 2015-09-30 01:33:11 UTC 
already pushed