GNOME Bugzilla – Bug 755499
popover: Fix crash when popover is NULL
Last modified: 2017-08-03 21:15:45 UTC
.
Created attachment 311987 [details] [review] popover: Fix crash when popover is NULL When the popover was NULL, we'd access invalid memory before the g_return_if_fail guards.
hitting the g_return_if_fail is as good as a crash, so this makes little practical difference.
(In reply to Matthias Clasen from comment #2) > hitting the g_return_if_fail is as good as a crash, so this makes little > practical difference. Except that it will actually be showing as a g_return_if_fail() in the stack traces, instead of null pointers dereferences.
Or put a g_assert() here if the intent is crashing.
Timm fixed this in commit 0d17421ffdc3b6d3d47eaa38791f84e6111fe3f0
*** This bug has been marked as a duplicate of bug 746139 ***