Created attachment 311962 [details] [review]
videotestsrc: Force alpha downstream if foreground color contains alpha

Otherwise the foreground color won't be fully represented in the
outputted frames.

I would like to get that fixed in the 1.6 branch, is it possible to merge that patch there or should I work around it in GES?

Comment on attachment 311962 [details] [review]
videotestsrc: Force alpha downstream if foreground color contains alpha

Not sure if this is a good idea. Pipelines that worked before are failing now, people might've just left alpha unset for example. Maybe just make it a warning and *prefer* alpha formats?

Also this is only really relevant for a few patterns, not all of them, right?

Created attachment 312799 [details] [review]
videotestsrc: Force alpha downstream if foreground color contains alpha

Otherwise the foreground color won't be fully represented in the
outputted frames.

(In reply to Sebastian Dröge (slomo) from comment #3)
> Comment on attachment 311962 [details] [review] [review]
> videotestsrc: Force alpha downstream if foreground color contains alpha
> 
> Not sure if this is a good idea. Pipelines that worked before are failing
> now, people might've just left alpha unset for example. Maybe just make it a
> warning and *prefer* alpha formats?

I just WARN if downstream does not support alpha and keep old behaviour in that case.

> Also this is only really relevant for a few patterns, not all of them, right?

It is potentially relevant for all patterns afaiu.

commit ab6b536a66e6ef47a2ff77946d3e52a06c06d0d4
Author: Thibault Saunier <tsaunier@gnome.org>
Date:   Wed Sep 23 18:47:52 2015 +0200

    videotestsrc: Force alpha downstream if foreground color contains alpha
    
    Otherwise the foreground color won't be fully represented in the
    outputted frames.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=755482