After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755364 - make gtkdoc-check happy again
make gtkdoc-check happy again
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: docs
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-09-21 17:27 UTC by Xavier Claessens
Modified: 2015-10-30 14:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Doc: fix some gtk-doc warnings (2.81 KB, patch)
2015-09-21 17:28 UTC, Xavier Claessens
none Details | Review
Doc: fix some gtk-doc warnings (2.86 KB, patch)
2015-09-21 17:51 UTC, Xavier Claessens
accepted-commit_now Details | Review

Description Xavier Claessens 2015-09-21 17:27:53 UTC
.
Comment 1 Xavier Claessens 2015-09-21 17:28:11 UTC
Created attachment 311784 [details] [review]
Doc: fix some gtk-doc warnings
Comment 2 Xavier Claessens 2015-09-21 17:29:58 UTC
With that patch and the one from bug #744061, remaining issues are:

1) g_set_object() inline confuses gtk-doc and it complains for unused old_object.

2) gio has undocumented win32 APIs:
GWin32RegistryKey
GWin32RegistryKeyWatcherFlags (<items>)
GWin32RegistrySubkeyIter
GWin32RegistryValueIter
GWin32RegistryValueType (<items>)
Comment 3 Xavier Claessens 2015-09-21 17:51:52 UTC
Created attachment 311791 [details] [review]
Doc: fix some gtk-doc warnings
Comment 4 Xavier Claessens 2015-09-21 17:53:23 UTC
Fixed the doc of g_file_monitor_emit_event() that was removed in commit 737ab3201163631be152801a859b3874a667f10. It is now the implementation that is responsible to call that method from the right thread if I understand correctly.
Comment 5 Allison Karlitskaya (desrt) 2015-10-30 10:18:26 UTC
Review of attachment 311791 [details] [review]:

Looks good.  Thanks for playing this game :)

::: gio/gfilemonitor.c
@@ +273,3 @@
+ * Implementations are responsible to call this method from the
+ * [thread-default main context][g-main-context-push-thread-default] of the
+ * thread that the monitor was created in.

This is not _strictly_ true, but it's good enough.  In fact, I think it's true for all external users of the API...
Comment 6 Xavier Claessens 2015-10-30 14:31:56 UTC
Thanks, pushed. Also fixed missing g_sequence_is_empty() and g_socket_connectable_to_string() while at it.