After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755210 - Fix possible use after free
Fix possible use after free
Status: RESOLVED FIXED
Product: libdmapsharing
Classification: Other
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: W. Michael Petullo
W. Michael Petullo
Depends on:
Blocks:
 
 
Reported: 2015-09-18 09:57 UTC by Bastien Nocera
Modified: 2016-11-12 01:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove memory failure check (1.05 KB, patch)
2015-09-18 09:57 UTC, Bastien Nocera 		none Details | Review
Fix possible use after free (1.17 KB, patch)
2015-09-18 09:57 UTC, Bastien Nocera 		rejected Details | Review

Description Bastien Nocera 2015-09-18 09:57:33 UTC 
.
Comment 1 Bastien Nocera 2015-09-18 09:57:38 UTC 
Created attachment 311618 [details] [review]
Remove memory failure check

GLib never fails to allocate memory. At least not in a way that
applications can do anything about it.

"If any call to allocate memory fails, the application is terminated.
This also means that there is no need to check if the call succeeded."
Comment 2 Bastien Nocera 2015-09-18 09:57:44 UTC 
Created attachment 311619 [details] [review]
Fix possible use after free

We need to dispose of cd->stream before trying to dispose of cd, or
we'll be accessing freed memory.

See https://bugzilla.redhat.com/show_bug.cgi?id=1024020#c27
Comment 3 Bastien Nocera 2016-04-12 09:08:05 UTC 
Review of attachment 311619 [details] [review]:

Was fixed in bug 749886.
Comment 4 gnome.vrb 2016-10-25 14:15:30 UTC 
Can this bug be closed ?
Comment 5 Bastien Nocera 2016-10-25 14:20:48 UTC 
(In reply to vrishab from comment #4)
> Can this bug be closed ?

No, there's an unreviewed patch still here.
Comment 6 W. Michael Petullo 2016-11-12 01:20:01 UTC 
I just applied attachment 311618 [details] [review] to master.