Created attachment 311560 [details] [review]
room: Be more strict when highlighting messages

We currently highlight a messages if it contains the nick we match on,
regardless of where the match occurs. While this simplistic approach
works well enough for most nicks, it results in an annoying amount of
false positives for nicks that commonly appear in words. So tighten our
matching to require non-alphanumeric characters before and after the
nick.

Review of attachment 311560 [details] [review]:

>> We currently highlight a messages
s/messages/message

>> So tighten our matching to require non-alphanumeric characters before and after the nick.
I misinterpret this as that you have to have non-alphanumeric characters before and after the nick. how about "So tighten our matching to stop matching alphanumeric characters before and after the nick." ?

couldn't read the code sry. :-)

Created attachment 311566 [details] [review]
room: Be more strict when highlighting messages

(In reply to Bastian Ilsø from comment #2)
> >> So tighten our matching to require non-alphanumeric characters before and after the nick.
> I misinterpret this as that you have to have non-alphanumeric characters
> before and after the nick.

To your defense, that's what the message says - it's mostly accurate, except that we consider the very beginning or end of the message as "non-alphanumeric" (in the latter case, that's technically true for '\0'-terminated strings).


> couldn't read the code sry. :-)

Here's a less concise version, is that better?

(In reply to Florian Müllner from comment #3)
> Here's a less concise version, is that better?

yes :)

btw still an s too much in "messages" (should be "message" i assume?)

Attachment 311566 [details] pushed as 2d06b9e - room: Be more strict when highlighting messages