After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755113 - Regression: dvbsuboverlay negotiates invalid caps
Regression: dvbsuboverlay negotiates invalid caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.5.90
Other Linux
: Normal blocker
: 1.5.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-16 13:55 UTC by Jan Schmidt
Modified: 2015-09-16 15:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dvbsuboverlay: Check if downstream supports GstVideoOverlayComposition. (2.13 KB, patch)
2015-09-16 14:05 UTC, Jan Schmidt 		none Details | Review

Description Jan Schmidt 2015-09-16 13:55:20 UTC 
Recent changes to caps nego mean dvbsuboverlay now outputs caps with GstVideoOverlayComposition even if downstream can't handle them, because it only checks accept_caps and not a full peer caps intersection.

Patch coming.
Comment 1 Jan Schmidt 2015-09-16 14:05:56 UTC 
Created attachment 311456 [details] [review]
dvbsuboverlay: Check if downstream supports GstVideoOverlayComposition.

Fix the negotiation of GstVideoOverlayComposition by checking
intersection with the peer caps, rather than just accept-caps,
which might only check the pad template.
Comment 2 Sebastian Dröge (slomo) 2015-09-16 14:10:45 UTC 
Please check if the same bug exists in dvdspu and textoverlay :)
Comment 3 Jan Schmidt 2015-09-16 14:20:35 UTC 
I stole the code from textoverlay ;)
dvdspu GstVideoCompositionOverlay support isn't merged yet.